Remove fragment string in request path#846
Closed
carlcarl wants to merge 1 commit intoaio-libs:0.21from
Closed
Conversation
The request path should not include the # fragment. The request url can still keep this.
Contributor
Author
|
Any suggestion? |
Member
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What these changes does?
It remove the fragment string begin with
#in request.path.This should not be sent to the server with the url
The request.url still keeps the original format.
How to test your changes?
Sample code:
python3 -m http.server127.0.0.1 - - ... "GET /test#123 HTTP/1.1" 404 -, fixed will be127.0.0.1 - - ... "GET /test HTTP/1.1" 404 -Related issue number
#824
Checklist