Allow to pass None as a timeout value to disable timeout logic#834
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Mar 21, 2016
alexkey:disable_timeout_with_none
Merged
Allow to pass None as a timeout value to disable timeout logic#834asvetlov merged 2 commits intoaio-libs:masterfrom alexkey:disable_timeout_with_none
asvetlov merged 2 commits intoaio-libs:masterfrom
alexkey:disable_timeout_with_none
Conversation
In some cases there is needed to disable timeout logic but keep it in convenient code structure without ugly if-branching.
asvetlov
added a commit
that referenced
this pull request
Mar 21, 2016
Allow to pass None as a timeout value to disable timeout logic
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What these changes does?
Allows to pass
Noneas a timeout value to disable timeout logic.In some cases there is needed to disable timeout logic but keep it in convenient code structure without ugly if-branching like this:
Now it is able to use the same code for both numerical and
Nonetimeout values:This behaviour is similar to
asyncio.wait_for(fut, timeout, *, loop=None)coroutine, which takesNoneas a timeout value to block until the future completes.How to test your changes?
There is a test in
test_timeout.py:test_timeout_disable.Related issue number
None.
Checklist