Fix blocking I/O in the event loop while processing files in a post request#8283
Fix blocking I/O in the event loop while processing files in a post request#8283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8283 +/- ##
==========================================
+ Coverage 97.49% 97.56% +0.06%
==========================================
Files 107 107
Lines 32987 32990 +3
Branches 3853 3853
==========================================
+ Hits 32162 32187 +25
+ Misses 606 588 -18
+ Partials 219 215 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
Production test on this one is good as well |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8293 🤖 @patchback |
…equest (#8283) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> (cherry picked from commit 54e13b0)
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8294 🤖 @patchback |
…equest (#8283) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> (cherry picked from commit 54e13b0)
…while processing files in a post request (#8293) Co-authored-by: J. Nick Koston <[email protected]>
… while processing files in a post request (#8294) Co-authored-by: J. Nick Koston <[email protected]>
What do these changes do?
Fix blocking I/O in the event loop while processing files in a post request
It looks like this was introduced in f2dbdf9
Are there changes in behavior for the user?
event loop is not blocked
Is it a substantial burden for the maintainers to support this?
no
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.