UrlDispatcher.add_route with partial coroutine handler#814
Conversation
| @asyncio.coroutine | ||
| def handler_wrapper(*args, **kwargs): | ||
| result = handler(*args, **kwargs) | ||
| if asyncio.iscoroutine(result): |
Member
There was a problem hiding this comment.
Please add a check for asyncio.Future also.
Author
There was a problem hiding this comment.
according to current documentation (for UrlDispatcher.add_route and Resource.add_route) handler should be callable which excludes asyncio.Future
Member
|
Tests needed. |
Author
|
test added |
asvetlov
added a commit
that referenced
this pull request
Mar 12, 2016
UrlDispatcher.add_route with partial coroutine handler
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for problem when partialy applied coroutine is used as handler for UrlDispatcher.add_route
similar issue:
http://bugs.python.org/issue23519