Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (43f92fa) to head (605453e).
Report is 1273 commits behind head on master.

@@           Coverage Diff           @@
##           master    #7942   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         107      107           
  Lines       32346    32346           
  Branches     3748     3748           
=======================================
  Hits        31516    31516           
  Misses        629      629           
  Partials      201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I think that looks fine to me.

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 0b71e1c on top of patchback/backports/3.10/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942

Backporting merged PR #7942 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.10/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942 upstream/3.10

4. Now, cherry-pick PR added server_hostname param to ws_connect method #7942 contents into that branch:

   $ git cherry-pick -x 0b71e1ce595f8ac489d13b05bc9fc468ff4250b0

   If it'll yell at you with something like fatal: Commit 0b71e1ce595f8ac489d13b05bc9fc468ff4250b0 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 0b71e1ce595f8ac489d13b05bc9fc468ff4250b0

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR added server_hostname param to ws_connect method #7942 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.10/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

If you could follow the backport instructions, that'd be appreciated.

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 0b71e1c on top of patchback/backports/3.11/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942

Backporting merged PR #7942 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.11/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942 upstream/3.11

4. Now, cherry-pick PR added server_hostname param to ws_connect method #7942 contents into that branch:

   $ git cherry-pick -x 0b71e1ce595f8ac489d13b05bc9fc468ff4250b0

   If it'll yell at you with something like fatal: Commit 0b71e1ce595f8ac489d13b05bc9fc468ff4250b0 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 0b71e1ce595f8ac489d13b05bc9fc468ff4250b0

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR added server_hostname param to ws_connect method #7942 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.11/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.