Tightening the runtime type check for ssl by xiangyan99 · Pull Request #7698 · aio-libs/aiohttp

xiangyan99 · 2023-10-13T19:39:40Z

Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None.

If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird.

In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context.

webknjaz

This would need motivation explanation, tests, change note. But overall, it just seems wrong.

…into fix_sslcontext

for more information, see https://pre-commit.ci

…into fix_sslcontext

aiohttp/client.py

for more information, see https://pre-commit.ci

aiohttp/helpers.py

Co-authored-by: Sviatoslav Sydorenko <[email protected]>

aiohttp/helpers.py

aiohttp/client.py

Co-authored-by: Sam Bull <[email protected]>

for more information, see https://pre-commit.ci

aiohttp/client.py

Co-authored-by: J. Nick Koston <[email protected]>

tests/test_connector.py

codecov · 2024-01-20T19:39:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25d96fa) 97.46% compared to head (d4b1340) 97.47%.
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7698      +/-   ##
==========================================
+ Coverage   97.46%   97.47%   +0.01%     
==========================================
  Files         107      107              
  Lines       32526    32604      +78     
  Branches     3791     3800       +9     
==========================================
+ Hits        31700    31782      +82     
+ Misses        624      618       -6     
- Partials      202      204       +2

Flag	Coverage Δ
CI-GHA	`97.39% <100.00%> (+0.01%)`	⬆️
OS-Linux	`97.06% <100.00%> (+0.01%)`	⬆️
OS-Windows	`95.57% <100.00%> (+0.03%)`	⬆️
OS-macOS	`96.70% <100.00%> (-0.18%)`	⬇️
Py-3.10.11	`95.50% <100.00%> (+0.03%)`	⬆️
Py-3.10.13	`96.87% <100.00%> (+<0.01%)`	⬆️
Py-3.11.7	`96.53% <100.00%> (-0.05%)`	⬇️
Py-3.12.1	`?`
Py-3.8.10	`95.47% <100.00%> (+0.03%)`	⬆️
Py-3.8.18	`96.80% <100.00%> (+0.01%)`	⬆️
Py-3.9.13	`95.47% <100.00%> (+0.03%)`	⬆️
Py-3.9.18	`96.84% <100.00%> (+0.01%)`	⬆️
Py-pypy7.3.13	`?`
Py-pypy7.3.15	`96.39% <100.00%> (?)`
VM-macos	`96.70% <100.00%> (-0.18%)`	⬇️
VM-ubuntu	`97.06% <100.00%> (+0.01%)`	⬆️
VM-windows	`95.57% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

patchback · 2024-01-20T19:59:43Z

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 9e14ea1 on top of patchback/backports/3.9/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698

Backporting merged PR #7698 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/aio-libs/aiohttp.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/3.9/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698 upstream/3.9

Now, cherry-pick PR Tightening the runtime type check for ssl #7698 contents into that branch:
```
$ git cherry-pick -x 9e14ea19b5a48bb26797babc32202605066cb5f5
```
If it'll yell at you with something like fatal: Commit 9e14ea19b5a48bb26797babc32202605066cb5f5 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x 9e14ea19b5a48bb26797babc32202605066cb5f5
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Tightening the runtime type check for ssl #7698 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/3.9/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2024-01-20T19:59:48Z

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 9e14ea1 on top of patchback/backports/3.10/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698

Backporting merged PR #7698 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/aio-libs/aiohttp.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/3.10/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698 upstream/3.10

Now, cherry-pick PR Tightening the runtime type check for ssl #7698 contents into that branch:
```
$ git cherry-pick -x 9e14ea19b5a48bb26797babc32202605066cb5f5
```
If it'll yell at you with something like fatal: Commit 9e14ea19b5a48bb26797babc32202605066cb5f5 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x 9e14ea19b5a48bb26797babc32202605066cb5f5
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Tightening the runtime type check for ssl #7698 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/3.10/9e14ea19b5a48bb26797babc32202605066cb5f5/pr-7698

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None. If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird. In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Sam Bull <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 9e14ea1)

Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None. If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird. In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Sam Bull <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 9e14ea1) (cherry picked from commit 4b91b53)

…or ssl (#7698) (#8043) **This is a backport of PR #8042 as merged into 3.10 (4b91b53).** Currently, the valid types of ssl parameter are SSLContext, Literal[False], Fingerprint or None. If user sets ssl = False, we disable ssl certificate validation which makes total sense. But if user set ssl = True by mistake, instead of enabling ssl certificate validation or raising errors, we silently disable the validation too which is a little subtle but weird. In this PR, we added a check that if user sets ssl=True, we enable certificate validation by treating it as using Default SSL Context. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Sam Bull <[email protected]> Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 9e14ea1)

Issue exposed by aio-libs/aiohttp#7698

commit 66ad247 Merge: 113a324 46aacd1 Author: Cisphyx <[email protected]> Date: Tue Feb 20 09:33:48 2024 -0500 Merge branch 'master' into synapse-3xx commit 46aacd1 Author: mikemoritz <[email protected]> Date: Tue Feb 20 04:54:03 2024 -0800 Support mTLS in HTTP requests (SYN-5896) (#3566) commit b63a63c Author: Cisphyx <[email protected]> Date: Tue Feb 20 07:53:13 2024 -0500 Deprecate $lib.bytes (SYN-6861) (#3570) commit aba2a37 Author: blackout <[email protected]> Date: Fri Feb 16 09:14:16 2024 -0500 Update CI for rerunning failed tests only (#3569) Update circleci.yaml to use `circleci tests run` instead of `circleci tests split` so the new(-ish) "rerun failed tests" feature works. This should hopefully save us a bunch of time (and $$$) by not having to rerun the entire test suite when one or two flaky tests fail. --------- Co-authored-by: Cisphyx <[email protected]> commit 4f4fa04 Author: epiphyte <[email protected]> Date: Fri Feb 16 02:20:41 2024 +0000 Bump version: 2.161.0 → 2.162.0 commit d00a7e5 Author: vEpiphyte <[email protected]> Date: Thu Feb 15 20:40:03 2024 -0500 Changelog for v2.162.0 (#3572) Co-authored-by: invisig0th <[email protected]> Co-authored-by: Cisphyx <[email protected]> commit 0d46f09 Author: Cisphyx <[email protected]> Date: Thu Feb 15 12:10:49 2024 -0500 Include vars from the current and parent scopes when resolving STIX properties and relationships (#3571) Co-authored-by: invisig0th <[email protected]> commit 33ea54d Author: Cisphyx <[email protected]> Date: Thu Feb 15 11:59:04 2024 -0500 Adjust tag permissions check during merges (SYN-6830) (#3545) commit 8569761 Author: invisig0th <[email protected]> Date: Thu Feb 15 11:54:06 2024 -0500 Fix bug where users may vote for their own merge (#3565) commit 7487841 Author: mikemoritz <[email protected]> Date: Thu Feb 15 08:23:08 2024 -0800 Add rstorm onload waiters (SYN-6871) (#3567) commit 2a80656 Author: Cisphyx <[email protected]> Date: Wed Feb 14 16:34:04 2024 -0500 Add perm checks with default=True to $lib.bytes (SYN-6859) (#3563) Co-authored-by: invisig0th <[email protected]> commit ad1dc70 Author: invisig0th <[email protected]> Date: Wed Feb 14 16:24:59 2024 -0500 Add received:from:ipv4/ipv6/fqdn to inet:email:message (#3564) commit 113a324 Merge: 687a09e 977c8c7 Author: Cisphyx <[email protected]> Date: Wed Feb 14 15:36:30 2024 -0500 Merge branch 'master' into synapse-3xx commit 977c8c7 Author: therealsilence <[email protected]> Date: Wed Feb 14 10:15:22 2024 -0800 Storm update (Part 1) (#3560) Update Storm lift and filter documentation to add: - Wildcard lifts and filters - Interface lifts and filters - Minor clarification to subqueries page --------- Co-authored-by: Cisphyx <[email protected]> commit f700eaf Author: Cisphyx <[email protected]> Date: Wed Feb 14 09:35:20 2024 -0500 Deprecate upstream/mirror layer opts (SYN-6839) (#3562) commit 949e3c1 Author: invisig0th <[email protected]> Date: Mon Feb 12 12:57:35 2024 -0500 Model updates 2024-02-08 (#3551) Co-authored-by: blackout <[email protected]> commit 93e9eef Author: blackout <[email protected]> Date: Mon Feb 12 11:44:35 2024 -0500 SYN-6798: add aha info to tele:syn response (#3552) feat: Add aha service name to the tele:syn message from the server if present. commit 344a667 Author: blackout <[email protected]> Date: Fri Feb 9 11:04:27 2024 -0500 SYN-6848: :url added to ou:id:type (#3549) feat: Added ``:url`` secondary property to ``ou:id:type``. commit 158f366 Author: vEpiphyte <[email protected]> Date: Fri Feb 9 11:04:02 2024 -0500 Fix use of updateHttpSessInfo by cells that haven't loaded a sess into memory (#3556) commit 36c50e3 Author: blackout <[email protected]> Date: Fri Feb 9 09:31:57 2024 -0500 SYN-6814: Add note about Synapse not a data lake (#3553) Updated the introduction page with a note about Synapse not being a data lake. Preview: ![image](https://github.com/vertexproject/synapse/assets/11776738/23cc93f2-668e-496b-979b-695dfd8ae7b5) --------- Co-authored-by: invisig0th <[email protected]> commit cc8df69 Author: blackout <[email protected]> Date: Fri Feb 9 09:29:20 2024 -0500 SYN-6763: $str.json() (#3555) feat: Add ``.json()`` method to storm strings. commit fcc5ead Author: vEpiphyte <[email protected]> Date: Fri Feb 9 09:28:34 2024 -0500 Update trove classifiers (SYN-6809) (#3557) commit c37e54c Author: vEpiphyte <[email protected]> Date: Wed Feb 7 17:42:53 2024 -0500 benchmark_cortex.py, change eval -> storm (#3550) commit 1497e59 Author: therealsilence <[email protected]> Date: Wed Feb 7 11:03:03 2024 -0800 Update Synapse User Guide "Automation" docs (#3547) - Revise, update, and organize docs - Add discussion of impact on automation of views & layers, scope, and permissions - Add details and example for edge:add / edge:del triggers - Add details and examples for modifying macro permissions - Update examples and provide additional detail on example Storm - Incidental corrections / additions to other docs --------- Co-authored-by: Cisphyx <[email protected]> commit a3b57b7 Author: blackout <[email protected]> Date: Wed Feb 7 11:13:45 2024 -0500 SYN-6400: $lib.dict.keys() and friends (#3548) deprecated: `$lib.dict()` feat: Added ``$lib.dict.has()``, ``$lib.dict.keys()``, ``$lib.dict.pop()``, ``$lib.dict.update()``, and ``$lib.dict.values()`` library functions. --------- Co-authored-by: epiphyte <[email protected]> commit 75088cc Author: epiphyte <[email protected]> Date: Tue Feb 6 17:42:18 2024 +0000 Bump version: 2.160.0 → 2.161.0 commit 914c41b Author: epiphyte <[email protected]> Date: Tue Feb 6 17:42:14 2024 +0000 Fix an RST error in the changelog. commit c3b02d9 Author: vEpiphyte <[email protected]> Date: Tue Feb 6 12:27:25 2024 -0500 Changelog for v2.161.0 (#3536) Co-authored-by: Cisphyx <[email protected]> Co-authored-by: blackout <[email protected]> commit 494b64a Author: vEpiphyte <[email protected]> Date: Mon Feb 5 14:47:14 2024 -0500 Make quorum tests a little more robust (#3546) Co-authored-by: Cisphyx <[email protected]> commit 01928f8 Author: vEpiphyte <[email protected]> Date: Mon Feb 5 13:22:48 2024 -0500 Add a method to the http session to do a bulk value set (#3544) Co-authored-by: invisig0th <[email protected]> commit 1ae99f7 Author: invisig0th <[email protected]> Date: Mon Feb 5 12:07:34 2024 -0500 Add getMergeRequest() and getMergeRequestSummary() to storm view object (#3541) commit 687a09e Author: Cisphyx <[email protected]> Date: Mon Feb 5 11:02:31 2024 -0500 Clean up IndxBy in layer (#3543) commit 64b303d Author: mikemoritz <[email protected]> Date: Fri Feb 2 12:09:46 2024 -0800 Add gen command for it:av:scan:result (SYN-6661) (#3516) Co-authored-by: Cisphyx <[email protected]> Co-authored-by: epiphyte <[email protected]> commit e1de8d7 Author: Cisphyx <[email protected]> Date: Fri Feb 2 13:55:40 2024 -0500 Fix AHA pool replay test inconsistency (#3539) Co-authored-by: epiphyte <[email protected]> commit 178d478 Author: vEpiphyte <[email protected]> Date: Fri Feb 2 10:02:21 2024 -0500 Feat dep updates (#3540) vertexproject/vtx-base-image#578 vertexproject/vtx-base-image#559 commit f6e5386 Author: cisphyx <[email protected]> Date: Fri Feb 2 08:40:49 2024 -0500 update test commit 94d2b5f Merge: e6f9b9e 8f511ae Author: Cisphyx <[email protected]> Date: Fri Feb 2 08:26:53 2024 -0500 Merge branch 'master' into synapse-3xx commit e6f9b9e Author: Cisphyx <[email protected]> Date: Fri Feb 2 08:25:37 2024 -0500 Remove upstream/mirror layers (#3537) commit 8f511ae Author: James Gross <[email protected]> Date: Thu Feb 1 15:12:37 2024 -0500 Back out trigger setting created time (#3538) commit 6fd753e Author: James Gross <[email protected]> Date: Thu Feb 1 14:23:04 2024 -0500 Add some more created timestamps around, part of SYN-6358 (#3521) commit da6a412 Author: cisphyx <[email protected]> Date: Thu Feb 1 13:31:24 2024 -0500 fixes from merge commit 5d07c34 Merge: 7bc092f f0b9e0f Author: Cisphyx <[email protected]> Date: Thu Feb 1 13:01:32 2024 -0500 Merge branch 'master' into synapse-3xx commit f0b9e0f Author: vEpiphyte <[email protected]> Date: Thu Feb 1 10:31:55 2024 -0500 Add aha information to getCellInfo (SYN-6764) (#3519) Add an aha dict to cell information, populated with name, leader, and network information. commit dca9836 Author: therealsilence <[email protected]> Date: Thu Feb 1 07:14:54 2024 -0800 Update Synapse User Guide - data model docs (#3523) - Add information on interfaces - Add information on extended forms and extended properties - Clarify "edge forms" - Minor updates / revisions --------- Co-authored-by: Cisphyx <[email protected]> Co-authored-by: invisig0th <[email protected]> commit 19a99c9 Author: vEpiphyte <[email protected]> Date: Thu Feb 1 09:10:42 2024 -0500 Set aha logs to info level (SYN-6519) (#3534) commit 58efa7b Author: Cisphyx <[email protected]> Date: Wed Jan 31 17:12:33 2024 -0500 Pass edited nodes to snap._applyNodeEdits (#3520) commit fa2a0b6 Author: vEpiphyte <[email protected]> Date: Tue Jan 30 23:03:03 2024 -0500 Fix pkg onload test race (#3533) commit c7c7530 Author: Cisphyx <[email protected]> Date: Tue Jan 30 13:32:33 2024 -0500 Ensure Nexus events written to the log are always applied (SYN-6807) (#3518) commit f9bce5a Author: blackout <[email protected]> Date: Tue Jan 30 13:18:53 2024 -0500 SYN-6727: more context for easy perm auth deny (#3532) commit 761a90d Author: James Gross <[email protected]> Date: Mon Jan 29 14:38:52 2024 -0500 Fix some bad names in graph projection, part of OP-3028 (#3531) commit 7f7bbfc Author: vEpiphyte <[email protected]> Date: Mon Jan 29 12:49:52 2024 -0500 CI: Update cache keys to be consistent, replace CIRCLE_STAGE with CIRCLE_JOB (#3528) commit d11dc2f Author: Cisphyx <[email protected]> Date: Mon Jan 29 12:36:43 2024 -0500 Update EmbedQuery to grab vars from parent scopes (#3529) Co-authored-by: vEpiphyte <[email protected]> commit 1049735 Author: Cisphyx <[email protected]> Date: Mon Jan 29 12:24:28 2024 -0500 Delete pool entry from leader in query offload test (#3530) commit d808662 Author: vEpiphyte <[email protected]> Date: Mon Jan 29 11:24:05 2024 -0500 Fix missing fstring (#3525) commit 996fa30 Author: vEpiphyte <[email protected]> Date: Mon Jan 29 11:23:29 2024 -0500 Bug: Fix websocket connect ssl handling (SYN-6812) (#3527) Issue exposed by aio-libs/aiohttp#7698 commit 43fb572 Author: blackout <[email protected]> Date: Fri Jan 26 09:13:16 2024 -0500 SYN-6658: docs on ext props updated to note the need to delete values before removing them (#3510) docs: Update admin guide with additional info about updating extended model elements. commit d269eda Author: vEpiphyte <[email protected]> Date: Thu Jan 25 15:35:26 2024 -0500 Bug: Fix flakey test in test_lib_storm_basics (SYN-6804) (#3517) Co-authored-by: Cisphyx <[email protected]> commit a0885db Author: epiphyte <[email protected]> Date: Wed Jan 24 22:32:29 2024 +0000 Add inet:ipv6 update to the changelog. commit 26159d5 Author: epiphyte <[email protected]> Date: Wed Jan 24 22:28:32 2024 +0000 Bump version: 2.159.0 → 2.160.0 commit b7c57d0 Author: epiphyte <[email protected]> Date: Wed Jan 24 22:21:43 2024 +0000 Add missing migration to the changelog commit 9456d3b Author: vEpiphyte <[email protected]> Date: Wed Jan 24 17:08:39 2024 -0500 Changelog for v2.160.0 (#3511) Co-authored-by: Cisphyx <[email protected]> Co-authored-by: blackout <[email protected]> commit af5c3c0 Author: vEpiphyte <[email protected]> Date: Wed Jan 24 16:34:42 2024 -0500 Revert "SYN-6716: `it:sec:cpe` issues when converting from 2.2->2.3 and 2.3->2.2 (#3491)" (#3514) This reverts commit 4c98bc6. commit 149e25b Author: Cisphyx <[email protected]> Date: Wed Jan 24 15:15:12 2024 -0500 Add query offloading to count/exportStorm (SYN-6802) (#3513) commit 79dab62 Author: Cisphyx <[email protected]> Date: Wed Jan 24 13:00:57 2024 -0500 Add query offload mirrors (SYN-6046) (#3452) commit 6510252 Author: Cisphyx <[email protected]> Date: Wed Jan 24 12:54:03 2024 -0500 Use dict instead of list for prop type maps (#3512) commit 20fd23a Author: vEpiphyte <[email protected]> Date: Wed Jan 24 09:44:19 2024 -0500 Make layer pulls / push configurations tunable (#3480) commit ff60cb2 Author: invisig0th <[email protected]> Date: Wed Jan 24 09:00:04 2024 -0500 Adds node.set.<form>.<prop> perms convention ( backward compatible ) (#3505) commit 4240ca2 Author: blackout <[email protected]> Date: Tue Jan 23 16:24:31 2024 -0500 Revert CPE migration code and test (#3508) commit d0a2434 Author: blackout <[email protected]> Date: Tue Jan 23 15:44:11 2024 -0500 SYN-6363: `edges.del --n2` command can't delete edges with a missing N1 and the edge data sticks around (#3506) commit ba1ca2e Author: invisig0th <[email protected]> Date: Tue Jan 23 12:41:13 2024 -0500 Add IPv6 :type and :scope (#3498) Co-authored-by: blackout <[email protected]> commit 4c98bc6 Author: blackout <[email protected]> Date: Tue Jan 23 12:34:34 2024 -0500 SYN-6716: `it:sec:cpe` issues when converting from 2.2->2.3 and 2.3->2.2 (#3491) bugfix: Updated CPE code to support better conversions from 2.2->2.3 and vice versa --------- Co-authored-by: epiphyte <[email protected]> commit 0283588 Author: vEpiphyte <[email protected]> Date: Tue Jan 23 11:08:13 2024 -0500 Bug: Storm cli completion (#3507) Support older cortex without coreinfov2 update Ensure that tag completion runs in the current view commit e4621cb Author: blackout <[email protected]> Date: Mon Jan 22 19:29:50 2024 -0500 SYN-6652: --deledges option to delnode (#3503) commit 0e162b1 Author: blackout <[email protected]> Date: Mon Jan 22 19:07:36 2024 -0500 SYN-6647: tab completion in storm CLI (#3493) feat: Add tab completion in Storm CLI. Completes forms, properties, libs and tags. commit 98af04d Author: blackout <[email protected]> Date: Mon Jan 22 15:44:48 2024 -0500 SYN-6690: Update `it:exec:*` to inherit the `it:host:activity` interface (#3501) feat: Update `it:exec:*` forms to inherit the `it:host:activity` interface. --------- Co-authored-by: invisig0th <[email protected]> commit 7bc092f Merge: b7aaf2f 7d41562 Author: Cisphyx <[email protected]> Date: Mon Jan 22 15:41:15 2024 -0500 Merge branch 'master' into synapse-3xx commit b7aaf2f Author: cisphyx <[email protected]> Date: Mon Jan 22 15:41:00 2024 -0500 grab 3.0.0 bylayer fix commit 7d41562 Author: invisig0th <[email protected]> Date: Mon Jan 22 15:33:26 2024 -0500 Add :priority and :severity to risk:vuln (#3504) …:vuln convention. commit dc536a4 Author: cisphyx <[email protected]> Date: Mon Jan 22 15:26:17 2024 -0500 fix merge commit 27a6c70 Merge: cc747d2 a2a7e5b Author: Cisphyx <[email protected]> Date: Mon Jan 22 14:58:47 2024 -0500 Merge branch 'master' into synapse-3xx commit a2a7e5b Author: vEpiphyte <[email protected]> Date: Thu Jan 18 08:55:58 2024 -0500 Add Cell.hasHttpSess(iden) (#3485) commit 916adce Author: Cisphyx <[email protected]> Date: Thu Jan 18 08:51:24 2024 -0500 Fix node.bylayer data for tagprops (SYN-6743) (#3500) commit e07b15b Author: therealsilence <[email protected]> Date: Wed Jan 17 13:25:15 2024 -0800 Update Storm "filter" docs (#3489) - Add documentation for tag glob filtering - Add expression filter example for calculating intervals that fall *within* intervals - Reorganize / better structure docs - General editorial pass (update examples for current tag and model elements, overall cleanup) commit 4b78652 Author: mikemoritz <[email protected]> Date: Wed Jan 17 08:14:11 2024 -0800 Fire an event when a pkg onload completes (SYN-6752) (#3497) commit 1d8f9bb Author: Cisphyx <[email protected]> Date: Wed Jan 17 10:57:09 2024 -0500 Remove dataname index entries when wiping nodedata (SYN-6683) (#3499) Co-authored-by: invisig0th <[email protected]> commit e6b7281 Author: epiphyte <[email protected]> Date: Tue Jan 16 21:40:02 2024 +0000 Bump version: 2.158.0 → 2.159.0 commit b9c5c2d Author: vEpiphyte <[email protected]> Date: Tue Jan 16 16:26:35 2024 -0500 Changelog for v2.159.0 (#3496) Co-authored-by: Cisphyx <[email protected]> Co-authored-by: invisig0th <[email protected]> commit 2a2fd05 Author: vEpiphyte <[email protected]> Date: Tue Jan 16 14:25:51 2024 -0500 BUG: $lib.stix.import.ingest missing toprim on bundle (SYN-6749) (#3495) commit 340996a Author: mikemoritz <[email protected]> Date: Tue Jan 16 08:41:01 2024 -0800 Update vault permissions to always check for asroot (SYN-6726) (#3492) commit 9aa5d57 Author: James Gross <[email protected]> Date: Fri Jan 12 12:43:57 2024 -0500 `$lib.axon.urlfile` was missing a perms check for adding the nodes, part of SYN-6660 (#3490) commit 197bc8f Author: therealsilence <[email protected]> Date: Thu Jan 11 08:43:23 2024 -0800 Update Storm "lift" docs (#3487) - Add documentation for 'reverse' keyword - Reorganize / better structure docs - Clarify use of "try" operator - General editorial pass (update examples for current tag and model elements, overall cleanup) commit 29a59a7 Author: blackout <[email protected]> Date: Wed Jan 10 11:24:56 2024 -0500 SYN-6612: lark doesn't parse correctly with python 3.11.7 (#3488) - Update lark to 1.1.9 which has python 3.11.7 fix - Unpin CI images from 3.11.6 back to 3.11 commit 05b6bb7 Author: Cisphyx <[email protected]> Date: Thu Jan 4 16:17:23 2024 -0500 Prevent re-adding extended model elements in nexus handlers (#3486)

Not verify ssl cert only if it is explicitly set to false

af89acb

xiangyan99 requested a review from asvetlov as a code owner October 13, 2023 19:39

update

f950c10

webknjaz requested changes Oct 14, 2023

View reviewed changes

update

2a9c681

xiangyan99 changed the title ~~Not verify ssl cert only if it is explicitly set to false~~ verify ssl cert if user specifies ssl=True Oct 16, 2023

xiangyan99 and others added 6 commits October 16, 2023 16:00

Merge branch 'master' into fix_sslcontext

9cfba08

Tightening the runtime type check for ssl

3307165

Merge branch 'fix_sslcontext' of https://github.com/xiangyan99/aiohttp …

39dd338

…into fix_sslcontext

[pre-commit.ci] auto fixes from pre-commit.com hooks

9cbfc19

for more information, see https://pre-commit.ci

update error message

1a4418f

Merge branch 'fix_sslcontext' of https://github.com/xiangyan99/aiohttp …

8c97799

…into fix_sslcontext

xiangyan99 changed the title ~~verify ssl cert if user specifies ssl=True~~ Tightening the runtime type check for ssl Oct 17, 2023

Dreamsorcerer reviewed Oct 17, 2023

View reviewed changes

aiohttp/client.py Outdated Show resolved Hide resolved

xiangyan99 and others added 2 commits October 18, 2023 15:51

refactor verify_ssl_type method

6951153

[pre-commit.ci] auto fixes from pre-commit.com hooks

f66fc1d

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems Oct 18, 2023

View reviewed changes

aiohttp/helpers.py Fixed Show fixed Hide fixed

xiangyan99 and others added 5 commits October 18, 2023 16:37

Update aiohttp/helpers.py

4791edc

Co-authored-by: Sviatoslav Sydorenko <[email protected]>

Merge branch 'master' into fix_sslcontext

7bb9f8f

update

53a981d

update

de91f19

update

ae3bc13

Dreamsorcerer reviewed Oct 19, 2023

View reviewed changes

aiohttp/helpers.py Outdated Show resolved Hide resolved

aiohttp/helpers.py Outdated Show resolved Hide resolved

aiohttp/client.py Outdated Show resolved Hide resolved

xiangyan99 and others added 3 commits October 19, 2023 10:01

Update aiohttp/helpers.py

9725feb

Co-authored-by: Sam Bull <[email protected]>

Update aiohttp/helpers.py

e49e038

Co-authored-by: Sam Bull <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

94d4ad2

for more information, see https://pre-commit.ci

bdraco reviewed Nov 27, 2023

View reviewed changes

aiohttp/client.py Outdated Show resolved Hide resolved

xiangyan99 and others added 3 commits November 27, 2023 14:31

Update aiohttp/client.py

5187a7d

Co-authored-by: J. Nick Koston <[email protected]>

Merge branch 'master' into fix_sslcontext

de3b3ea

add test

2cce630

Create 7698.feature

67ed458

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 20, 2024

Dreamsorcerer added 9 commits January 20, 2024 15:54

Update client_exceptions.py

4b63a9a

Update client_reqrep.py

7e9142e

Update client.py

ccee556

Update test_connector.py

6d90b5f

Update test_proxy.py

94a043b

Update test_connector.py

e2a511a

Update test_client_exceptions.py

4e5c4a3

Update test_client_request.py

34d4e6b

Update test_client_exceptions.py

9eb658d

Dreamsorcerer reviewed Jan 20, 2024

View reviewed changes

tests/test_connector.py Outdated Show resolved Hide resolved

Dreamsorcerer reviewed Jan 20, 2024

View reviewed changes

tests/test_connector.py Outdated Show resolved Hide resolved

Apply suggestions from code review

effc111

Dreamsorcerer reviewed Jan 20, 2024

View reviewed changes

tests/test_connector.py Outdated Show resolved Hide resolved

Update tests/test_connector.py

d4b1340

Dreamsorcerer merged commit 9e14ea1 into aio-libs:master Jan 20, 2024

vEpiphyte mentioned this pull request Jan 29, 2024

Bug: Fix websocket connect ssl handling (SYN-6812) vertexproject/synapse#3527

Merged

vEpiphyte added a commit to vertexproject/synapse that referenced this pull request Jan 29, 2024

Bug: Fix websocket connect ssl handling (SYN-6812) (#3527)

996fa30

Issue exposed by aio-libs/aiohttp#7698

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tightening the runtime type check for ssl#7698

Tightening the runtime type check for ssl#7698
Dreamsorcerer merged 54 commits intoaio-libs:masterfrom
xiangyan99:fix_sslcontext

xiangyan99 commented Oct 13, 2023 •

edited

Loading

Uh oh!

webknjaz left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 20, 2024

Uh oh!

patchback bot commented Jan 20, 2024 •

edited

Loading

Uh oh!

patchback bot commented Jan 20, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

xiangyan99 commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webknjaz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 20, 2024

Codecov Report

Uh oh!

patchback bot commented Jan 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to 3.9: 💔 cherry-picking failed — conflicts found

Backporting merged PR #7698 into master

Uh oh!

patchback bot commented Jan 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to 3.10: 💔 cherry-picking failed — conflicts found

Backporting merged PR #7698 into master

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xiangyan99 commented Oct 13, 2023 •

edited

Loading

webknjaz left a comment •

edited

Loading

patchback bot commented Jan 20, 2024 •

edited

Loading

patchback bot commented Jan 20, 2024 •

edited

Loading