Skip to content

Make setup.cfg packages explicit#7684

Merged
Dreamsorcerer merged 1 commit intomasterfrom
Dreamsorcerer-patch-6
Oct 9, 2023
Merged

Make setup.cfg packages explicit#7684
Dreamsorcerer merged 1 commit intomasterfrom
Dreamsorcerer-patch-6

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

@Dreamsorcerer Dreamsorcerer commented Oct 9, 2023

Avoids accidentally including other packages.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels Oct 9, 2023
@Dreamsorcerer Dreamsorcerer mentioned this pull request Oct 9, 2023
Closed
8 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2023

Codecov Report

Merging #7684 (61b5e2f) into master (3d60762) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7684   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files         106      106           
  Lines       31630    31630           
  Branches     3619     3619           
=======================================
  Hits        30797    30797           
  Misses        630      630           
  Partials      203      203
Flag Coverage Δ
CI-GHA 97.28% <ø> (ø)
OS-Linux 96.95% <ø> (ø)
OS-Windows 95.43% <ø> (ø)
OS-macOS 96.62% <ø> (+<0.01%) ⬆️
Py-3.10.11 95.35% <ø> (ø)
Py-3.10.13 96.81% <ø> (ø)
Py-3.11.5 96.49% <ø> (-0.06%) ⬇️
Py-3.8.10 95.32% <ø> (ø)
Py-3.8.18 96.75% <ø> (ø)
Py-3.9.13 95.32% <ø> (ø)
Py-3.9.18 96.78% <ø> (+<0.01%) ⬆️
Py-pypy7.3.11 96.27% <ø> (ø)
VM-macos 96.62% <ø> (+<0.01%) ⬆️
VM-ubuntu 96.95% <ø> (ø)
VM-windows 95.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Oct 9, 2023

Do we include tests into sdists, by the way?

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Oct 9, 2023

I'd like to integrate https://github.com/marketplace/actions/checkout-python-sdist at some point, to make sure everything required for testing is included..

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Dreamsorcerer commented Oct 9, 2023

Do we include tests into sdists, by the way?

Should be handled by MANIFEST.in, I believe.

aiohttp/MANIFEST.in

Line 9 in 139069a

graft tests

@Dreamsorcerer Dreamsorcerer merged commit c0ba7e5 into master Oct 9, 2023
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-6 branch October 9, 2023 17:26
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Oct 9, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/c0ba7e537e6a959f553b3c299ae1c02066d4d194/pr-7684

Backported as #7687

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 9, 2023
@Dreamsorcerer @patchback
Make setup.cfg packages explicit (#7684)
49ff1bf 
(cherry picked from commit c0ba7e5)
@patchback patchback bot mentioned this pull request Oct 9, 2023
Merged
Dreamsorcerer pushed a commit that referenced this pull request Oct 9, 2023
@patchback
[PR #7684/c0ba7e53 backport][3.9] Make setup.cfg packages explicit (#…
492e8ee 
…7687)

**This is a backport of PR #7684 as merged into master
(c0ba7e5).**
Dreamsorcerer pushed a commit that referenced this pull request Oct 11, 2023
@ttsia
[PR #7684/30850ba backport][3.9] Fix #7306 - Set ClientWebSocketRespo…
dde1446 
…nse.close_code correctly in concu… (#7690)

This is a backport of PR #7680
as merged into master
(30850ba).

Fixes the issue when If one asyncio task is waiting on receiving data
and another asyncio task is closing the connection. The
ClientWebSocketResponse.close_code will be None after connection closed.
xiangxli pushed a commit to xiangxli/aiohttp that referenced this pull request Dec 4, 2023
@ttsia
[PR aio-libs#7684/30850ba backport][3.9] Fix aio-libs#7306 - Set Clie…
d38952f 
…ntWebSocketResponse.close_code correctly in concu… (aio-libs#7690)

This is a backport of PR aio-libs#7680
as merged into master
(aio-libs@30850ba).

Fixes the issue when If one asyncio task is waiting on receiving data
and another asyncio task is closing the connection. The
ClientWebSocketResponse.close_code will be None after connection closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dreamsorcerer @webknjaz