Fix #7306 - Set ClientWebSocketResponse.close_code correctly in concurrent closing scenario#7680
Merged
Dreamsorcerer merged 6 commits intoaio-libs:masterfrom Oct 9, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7680 +/- ##
==========================================
- Coverage 97.36% 97.36% -0.01%
==========================================
Files 106 106
Lines 31630 31648 +18
Branches 3619 3620 +1
==========================================
+ Hits 30797 30813 +16
- Misses 630 632 +2
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 30850ba on top of patchback/backports/3.9/30850babb43a8e28dd2df036776c62fd613d3d89/pr-7680 Backporting merged PR #7680 into master
🤖 @patchback |
Member
|
@ttsia Thanks for that. If you could create a backport with the above instructions, that'd be great. |
ttsia
added a commit
to ttsia/aiohttp
that referenced
this pull request
Oct 10, 2023
…in concurrent closing scenario (aio-libs#7680) (cherry picked from commit 30850ba)
Dreamsorcerer
pushed a commit
that referenced
this pull request
Oct 11, 2023
…nse.close_code correctly in concu… (#7690) This is a backport of PR #7680 as merged into master (30850ba). Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.
xiangxli
pushed a commit
to xiangxli/aiohttp
that referenced
this pull request
Dec 4, 2023
…ntWebSocketResponse.close_code correctly in concu… (aio-libs#7690) This is a backport of PR aio-libs#7680 as merged into master (aio-libs@30850ba). Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.
Related issue number
Fixes #7306
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.