Skip to content

Skip uvloop install on Python 3.12#7503

Merged
Dreamsorcerer merged 1 commit intoaio-libs:masterfrom
cdce8p:skip-uvloop
Aug 10, 2023
Merged

Skip uvloop install on Python 3.12#7503
Dreamsorcerer merged 1 commit intoaio-libs:masterfrom
cdce8p:skip-uvloop

Conversation

@cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Aug 10, 2023

What do these changes do?

Skip uvloop install on Python 3.12.
MagicStack/uvloop#547

Let's see if that unblocks the failing 3.12 tests.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #7503 (30cfeba) into master (c9176ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7503   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files         106      106           
  Lines       31452    31452           
  Branches     3571     3571           
=======================================
  Hits        30615    30615           
  Misses        634      634           
  Partials      203      203           
Flag Coverage Δ
CI-GHA 97.28% <ø> (ø)
OS-Linux 96.95% <ø> (ø)
OS-Windows 95.41% <ø> (ø)
OS-macOS 96.63% <ø> (ø)
Py-3.10.11 95.33% <ø> (ø)
Py-3.10.12 96.84% <ø> (ø)
Py-3.11.4 96.54% <ø> (ø)
Py-3.8.10 95.30% <ø> (ø)
Py-3.8.17 96.77% <ø> (ø)
Py-3.9.13 95.30% <ø> (ø)
Py-3.9.17 96.80% <ø> (ø)
Py-pypy7.3.11 96.34% <ø> (-0.01%) ⬇️
VM-macos 96.63% <ø> (ø)
VM-ubuntu 96.95% <ø> (ø)
VM-windows 95.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer
Copy link
Member

Thanks, looks like it could be some time before there's a new uvloop, so seems good to me.

@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Aug 10, 2023
@Dreamsorcerer Dreamsorcerer merged commit 53373c4 into aio-libs:master Aug 10, 2023
Dreamsorcerer added a commit that referenced this pull request Aug 10, 2023
## What do these changes do?
Ignore `dateutil` DeprecationWarning on Python 3.12.
It's already fixed on upstream
dateutil/dateutil#1285. Just waiting for a new
release now.

Requires #7503

---------

Co-authored-by: Sam Bull <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
patchback bot pushed a commit that referenced this pull request Aug 10, 2023
## What do these changes do?
Ignore `dateutil` DeprecationWarning on Python 3.12.
It's already fixed on upstream
dateutil/dateutil#1285. Just waiting for a new
release now.

Requires #7503

---------

Co-authored-by: Sam Bull <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
(cherry picked from commit 40203b7)
@patchback
Copy link
Contributor

patchback bot commented Aug 10, 2023

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 53373c4 on top of patchback/backports/3.9/53373c49aaf57c0239bb26046effbf2159102eb0/pr-7503

Backporting merged PR #7503 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.9/53373c49aaf57c0239bb26046effbf2159102eb0/pr-7503 upstream/3.9
  4. Now, cherry-pick PR Skip uvloop install on Python 3.12 #7503 contents into that branch:
    $ git cherry-pick -x 53373c49aaf57c0239bb26046effbf2159102eb0
    If it'll yell at you with something like fatal: Commit 53373c49aaf57c0239bb26046effbf2159102eb0 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 53373c49aaf57c0239bb26046effbf2159102eb0
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Skip uvloop install on Python 3.12 #7503 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.9/53373c49aaf57c0239bb26046effbf2159102eb0/pr-7503
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer pushed a commit that referenced this pull request Aug 10, 2023
Dreamsorcerer added a commit that referenced this pull request Aug 10, 2023
(cherry picked from commit 53373c4)

Co-authored-by: Marc Mueller <[email protected]>
@cdce8p cdce8p deleted the skip-uvloop branch August 10, 2023 19:28
Dreamsorcerer pushed a commit that referenced this pull request Aug 10, 2023
…[3.12] (#7506)

**This is a backport of PR #7505 as merged into master
(40203b7).**

## What do these changes do?
Ignore `dateutil` DeprecationWarning on Python 3.12.
It's already fixed on upstream
dateutil/dateutil#1285. Just waiting for a new
release now.

Requires #7503

Co-authored-by: Marc Mueller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants