Skip to content

[PR #7366/1a48add0 backport][3.9] Improve error messages from C parser#7379

Merged
Dreamsorcerer merged 1 commit into
3.9from
patchback/backports/3.9/1a48add026e310bb42b7bd38689b281f6651d127/pr-7366
Jul 18, 2023
Merged

[PR #7366/1a48add0 backport][3.9] Improve error messages from C parser#7379
Dreamsorcerer merged 1 commit into
3.9from
patchback/backports/3.9/1a48add026e310bb42b7bd38689b281f6651d127/pr-7366

Conversation

@patchback

@patchback patchback Bot commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

This is a backport of PR #7366 as merged into master (1a48add).

This adds information to the error messages to show what causes the error.

Exception output looks like:

aiohttp.http_exceptions.BadHttpMessage: 400, message:
  Invalid header value char:

    b'Set-Cookie: abc\x01def\r'
                     ^

@patchback patchback Bot requested a review from asvetlov as a code owner July 18, 2023 19:55
@patchback patchback Bot mentioned this pull request Jul 18, 2023
Merged
@codecov

codecov Bot commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7379 (d80a4ef) into 3.9 (e7fe416) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.9    #7379   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         107      107           
  Lines       31593    31605   +12     
  Branches     4011     4013    +2     
=======================================
+ Hits        30733    30745   +12     
  Misses        653      653           
  Partials      207      207
Flag Coverage Δ
CI-GHA 97.22% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.90% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.52% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.43% <100.00%> (+<0.01%) ⬆️
Py-3.10.12 96.78% <100.00%> (+<0.01%) ⬆️
Py-3.11.0 96.50% <81.48%> (-0.02%) ⬇️
Py-3.8.10 94.41% <100.00%> (+<0.01%) ⬆️
Py-3.8.17 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.42% <100.00%> (+<0.01%) ⬆️
Py-3.9.17 96.76% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 94.12% <77.77%> (-0.02%) ⬇️
VM-macos 96.58% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.90% <100.00%> (+<0.01%) ⬆️
VM-windows 94.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/http_exceptions.py 100.00% <100.00%> (ø)
tests/test_http_exceptions.py 100.00% <100.00%> (ø)
tests/test_http_parser.py 99.09% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 15d1d92 into 3.9 Jul 18, 2023
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/1a48add026e310bb42b7bd38689b281f6651d127/pr-7366 branch July 18, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dreamsorcerer