Conversation
Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 3a54d37)
Codecov Report
@@ Coverage Diff @@
## 3.8 #7357 +/- ##
==========================================
- Coverage 97.39% 97.39% -0.01%
==========================================
Files 107 107
Lines 30996 30999 +3
Branches 3924 3925 +1
==========================================
+ Hits 30188 30190 +2
- Misses 604 605 +1
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
webknjaz
deleted the
patchback/backports/3.8/3a54d3785e4b314ca70aaafbee5b3ae8d409c18e/pr-7333
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #7333 as merged into master (3a54d37).
Fixes #3355
The type has been fixed in
typeshedas well, so the bug here would be highlighted in mypy 1.5+.python/typeshed#10346 (comment)