🐛 Fix RST in changelog template before links#7348
Merged
webknjaz merged 1 commit intoJul 8, 2023
Merged
Conversation
In corner cases, changelog fragments with things like detached link definitions (example: aio-libs#7346) cause RST rendering errors. This patch corrects this by injecting empty lines between the changelog entry bodies and their reference lists.
webknjaz
added
bot:chronographer:skip
Codecov Report
@@ Coverage Diff @@
## master #7348 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 106 106
Lines 31399 31399
Branches 3924 3924
=======================================
Hits 30547 30547
Misses 648 648
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #7349 🤖 @patchback |
patchback Bot
pushed a commit
that referenced
this pull request
Jul 8, 2023
(cherry picked from commit bf9d753)
Contributor
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #7350 🤖 @patchback |
patchback Bot
pushed a commit
that referenced
this pull request
Jul 8, 2023
(cherry picked from commit bf9d753)
webknjaz
added a commit
that referenced
this pull request
Jul 8, 2023
…ore links (#7350) **This is a backport of PR #7348 as merged into master (bf9d753).** In corner cases, changelog fragments with things like detached link definitions (example: #7346) cause RST rendering errors. This patch corrects this by injecting empty lines between the changelog entry bodies and their reference lists. Co-authored-by: Sviatoslav Sydorenko <[email protected]>
webknjaz
added a commit
that referenced
this pull request
Jul 8, 2023
…ore links (#7349) **This is a backport of PR #7348 as merged into master (bf9d753).** In corner cases, changelog fragments with things like detached link definitions (example: #7346) cause RST rendering errors. This patch corrects this by injecting empty lines between the changelog entry bodies and their reference lists. Co-authored-by: Sviatoslav Sydorenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In corner cases, changelog fragments with things like detached link definitions (example: #7346) cause RST rendering errors. This patch corrects this by injecting empty lines between the changelog entry bodies and their reference lists.