Skip to content

Mention encoding in yarl.URL#7343

Merged
webknjaz merged 1 commit into
masterfrom
Dreamsorcerer-patch-3
Jul 9, 2023
Merged

Mention encoding in yarl.URL#7343
webknjaz merged 1 commit into
masterfrom
Dreamsorcerer-patch-3

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Jul 7, 2023

Copy link
Copy Markdown
Member

Hopefully will reduce confusion for users (e.g. #7341).

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels Jul 7, 2023
@codecov

codecov Bot commented Jul 7, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7343 (af246aa) into master (8dfc3ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7343   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         106      106           
  Lines       31399    31399           
  Branches     3924     3924           
=======================================
  Hits        30547    30547           
  Misses        648      648           
  Partials      204      204
Flag Coverage Δ
CI-GHA 97.23% <ø> (ø)
OS-Linux 96.90% <ø> (ø)
OS-Windows 95.28% <ø> (-0.08%) ⬇️
OS-macOS 96.59% <ø> (-0.01%) ⬇️
Py-3.10.11 95.28% <ø> (ø)
Py-3.10.12 96.79% <ø> (-0.01%) ⬇️
Py-3.11.0 96.54% <ø> (ø)
Py-3.8.10 ?
Py-3.8.17 96.72% <ø> (ø)
Py-3.9.13 ?
Py-3.9.17 96.75% <ø> (ø)
Py-pypy7.3.11 94.23% <ø> (-0.01%) ⬇️
VM-macos 96.59% <ø> (-0.01%) ⬇️
VM-ubuntu 96.90% <ø> (ø)
VM-windows 95.28% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz changed the title Mention encoding in URL Mention encoding in yarl.URL Jul 9, 2023
@webknjaz webknjaz merged commit 1805758 into master Jul 9, 2023
@webknjaz webknjaz deleted the Dreamsorcerer-patch-3 branch July 9, 2023 00:40
@patchback

patchback Bot commented Jul 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/18057581c47de308c60d2f8ce405ba8bd9471ab0/pr-7343

Backported as #7355

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Jul 9, 2023
@Dreamsorcerer @patchback
Mention encoding in yarl.URL (#7343)
75d223a 
Ref #7341

(cherry picked from commit 1805758)
@patchback patchback Bot mentioned this pull request Jul 9, 2023
Merged
@patchback

patchback Bot commented Jul 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/18057581c47de308c60d2f8ce405ba8bd9471ab0/pr-7343

Backported as #7356

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Jul 9, 2023
@Dreamsorcerer @patchback
Mention encoding in yarl.URL (#7343)
c37f10b 
Ref #7341

(cherry picked from commit 1805758)
@patchback patchback Bot mentioned this pull request Jul 9, 2023
Merged
webknjaz pushed a commit that referenced this pull request Jul 9, 2023
@patchback @Dreamsorcerer
[PR #7343/18057581 backport][3.8] Mention encoding in yarl.URL (#7355)
dd8e24e 
Co-authored-by: Sam Bull <[email protected]>
webknjaz pushed a commit that referenced this pull request Jul 9, 2023
@patchback @Dreamsorcerer
[PR #7343/18057581 backport][3.9] Mention encoding in yarl.URL (#7356)
54c67d2 
Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dreamsorcerer @webknjaz