Skip to content

Fix TLS transport is None error#7333

Merged
webknjaz merged 3 commits intomasterfrom
Dreamsorcerer-patch-2
Jul 9, 2023
Merged

Fix TLS transport is None error#7333
webknjaz merged 3 commits intomasterfrom
Dreamsorcerer-patch-2

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

@Dreamsorcerer Dreamsorcerer commented Jul 1, 2023 •
edited by webknjaz
Loading

Fixes #3355

The type has been fixed in typeshed as well, so the bug here would be highlighted in mypy 1.5+.
python/typeshed#10346 (comment)

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner July 1, 2023 13:34
@Dreamsorcerer Dreamsorcerer requested a review from webknjaz July 1, 2023 13:34
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 1, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2023 •
edited
Loading

Codecov Report

Merging #7333 (ecda522) into master (6f3e7f4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7333      +/-   ##
==========================================
- Coverage   97.30%   97.27%   -0.03%     
==========================================
  Files         106      106              
  Lines       31456    31402      -54     
  Branches     3940     3925      -15     
==========================================
- Hits        30608    30547      -61     
- Misses        644      650       +6     
- Partials      204      205       +1
Flag Coverage Δ
CI-GHA 97.22% <0.00%> (+0.01%) ⬆️
OS-Linux 96.89% <0.00%> (+0.02%) ⬆️
OS-Windows 95.35% <0.00%> (+0.01%) ⬆️
OS-macOS 96.58% <0.00%> (+0.10%) ⬆️
Py-3.10.11 95.27% <0.00%> (-1.71%) ⬇️
Py-3.10.12 96.78% <0.00%> (+0.18%) ⬆️
Py-3.11.0 96.53% <0.00%> (+0.10%) ⬆️
Py-3.7.16 ?
Py-3.7.17 ?
Py-3.7.9 ?
Py-3.8.10 95.25% <0.00%> (+0.11%) ⬆️
Py-3.8.16 ?
Py-3.8.17 96.72% <0.00%> (+0.10%) ⬆️
Py-3.9.13 95.24% <0.00%> (+0.11%) ⬆️
Py-3.9.16 ?
Py-3.9.17 96.74% <0.00%> (+0.10%) ⬆️
Py-pypy7.3.11 94.22% <0.00%> (+0.10%) ⬆️
VM-macos 96.58% <0.00%> (+0.10%) ⬆️
VM-ubuntu 96.89% <0.00%> (+0.02%) ⬆️
VM-windows 95.35% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/connector.py 94.20% <0.00%> (-0.43%) ⬇️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer
Copy link
Copy Markdown
Member Author

Dreamsorcerer commented Jul 7, 2023

@webknjaz This one could probably go in the next release, if you think the change looks reasonable.

webknjaz
webknjaz reviewed Jul 9, 2023
View reviewed changes
@webknjaz webknjaz enabled auto-merge (squash) July 9, 2023 00:30
@webknjaz webknjaz changed the title Fix transport is None error Fix TLS transport is None error Jul 9, 2023
@webknjaz webknjaz merged commit 3a54d37 into master Jul 9, 2023
@webknjaz webknjaz deleted the Dreamsorcerer-patch-2 branch July 9, 2023 00:58
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Jul 9, 2023 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/3a54d3785e4b314ca70aaafbee5b3ae8d409c18e/pr-7333

Backported as #7357

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 9, 2023
@Dreamsorcerer @webknjaz @patchback
Fix transport is None error (#7333)
dbd76ab 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 3a54d37)
@patchback patchback bot mentioned this pull request Jul 9, 2023
Merged
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Jul 9, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/3a54d3785e4b314ca70aaafbee5b3ae8d409c18e/pr-7333

Backported as #7358

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 9, 2023
@Dreamsorcerer @webknjaz @patchback
Fix transport is None error (#7333)
d66ae93 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 3a54d37)
@patchback patchback bot mentioned this pull request Jul 9, 2023
Merged
webknjaz pushed a commit that referenced this pull request Jul 9, 2023
@patchback @Dreamsorcerer
[PR #7333/3a54d378 backport][3.8] Fix TLS transport is None error (#…
8d45f9c 
…7357)

Co-authored-by: Sam Bull <[email protected]>
Fixes #3355
@andig andig mentioned this pull request Jul 9, 2023
Closed
webknjaz pushed a commit that referenced this pull request Jul 9, 2023
@patchback @Dreamsorcerer
[PR #7333/3a54d378 backport][3.9] Fix TLS transport is None error (#…
13047ee 
…7358)

Co-authored-by: Sam Bull <[email protected]>
Fixes #3355
@Dreamsorcerer Dreamsorcerer mentioned this pull request Jul 9, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request.transport is sometimes None

2 participants

@Dreamsorcerer @webknjaz