Skip to content

Fix #271: Memory leak in request#723

Merged
asvetlov merged 1 commit into0.20from
fix_memleak
Jan 7, 2016
Merged

Fix #271: Memory leak in request#723
asvetlov merged 1 commit into0.20from
fix_memleak

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Jan 7, 2016

No description provided.

@fafhrd91
Copy link
Copy Markdown
Member

fafhrd91 commented Jan 7, 2016

why do you think add_headers() is the problem?

@asvetlov
Copy link
Copy Markdown
Member Author

asvetlov commented Jan 7, 2016

It is not add_headers() actually but generator unpacking.
See https://gist.github.com/asvetlov/227af16ae9eb38db7f22
We discovered the issue with @mpaolini last night.

Regarding to add_headers() -- it's just extra call which doesn't make any additional value.

@fafhrd91
Copy link
Copy Markdown
Member

fafhrd91 commented Jan 7, 2016

ok, i see.

asvetlov added a commit that referenced this pull request Jan 7, 2016
@asvetlov asvetlov merged commit ce89d36 into 0.20 Jan 7, 2016
@asvetlov asvetlov mentioned this pull request Jan 7, 2016
@asvetlov asvetlov deleted the fix_memleak branch January 7, 2016 21:52
@kxepal
Copy link
Copy Markdown
Member

kxepal commented Jan 7, 2016

@asvetlov Nice found! Is that CIMultiDict specific or general generator unpacking issue don't you know?

@asvetlov
Copy link
Copy Markdown
Member Author

asvetlov commented Jan 7, 2016

It's python unpacking issue.
Reproducible with any structure (dict, list, etc.).
I'm trying to investigate and maybe create a patch.

@mpaolini
Copy link
Copy Markdown
Contributor

mpaolini commented Jan 7, 2016

It did fix the leak that has been going on on my side since v0.14.0 at least. Thanks @asvetlov

@lock
Copy link
Copy Markdown

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants