Conversation
There was a problem hiding this comment.
Just curious, why not setter fortcp_nodelay property?
There was a problem hiding this comment.
I thought about property's setter but found that syscall worth explicit function call.
There was a problem hiding this comment.
if value not in (1,0):
raise ValueError('.....')
|
I'm finished. Flow can be controlled by I'll merge PR tomorrow. The only thing left is documentation. |
|
Is stream uncorked after writing last byte of response while in keep-alive mode ? |
|
Also, same technique should be applied to http client when it writes http request. |
|
I remember interesting technique in streaming over http and using chunked data. This cover not only EvenrSource http://www.w3schools.com/html/html5_serversentevents.asp but also videostreaming. I mean that in these cases each chunk of chunked response contains complete data that should be delivered to browserwith minimal delay. Even when delay between chunks are long. So, in current implemntation, user should uncork manually after sending chunk and cork again before sending chunk. Does not it ? If yes, please document that example. Also for websockets. Library should cork before sending frame and uncork afer sending. Is it so ? Sorry, but code slightly complicated for me. |
Second approach to solve nodelay issue