Conversation
(cherry picked from commit e1ed247)
5 tasks
Codecov Report
@@ Coverage Diff @@
## 3.9 #6403 +/- ##
======================================
Coverage ? 93.34%
======================================
Files ? 104
Lines ? 30456
Branches ? 3064
======================================
Hits ? 28429
Misses ? 1850
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
webknjaz
deleted the
patchback/backports/3.9/e1ed247dd3aa9a2fc3cd6d87b4845849da6ee494/pr-6400
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #6400 as merged into master (e1ed247).
This does not affect source distributions, and Cython sources (
.pyx) arestill installed.
What do these changes do?
Prevent C sources (
_find_header.c,_find_header.h,_helpers.c,_http_parser.c,_http_writer.c, and_websocket.c) from being included in binary distributions such as wheels, without affecting Cython sources (_cparser.pxd,_find_header.pxd,_headers.pxi,_helpers.pyx,_http_parser.pyx,_http_writer.pyx, and_websocket.pyx) or source distributions.Are there changes in behavior for the user?
Nothing changes except that the binary wheels are much smaller because they do not contain ~1.7MB of C sources.
Related issue number
Resolves #6399.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.