Merged
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #6134 +/- ##
==========================================
- Coverage 93.31% 93.30% -0.01%
==========================================
Files 102 102
Lines 30178 30180 +2
Branches 2701 2702 +1
==========================================
Hits 28160 28160
- Misses 1841 1843 +2
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
reviewed
Oct 27, 2021
Contributor
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6148 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Fix resetting SIGCHLD in Gunicorn Worker * add CONTRIBUTORS and add CHANGES * add CONTRIBUTORS and add CHANGES * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change CHANGES spell * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update aiohttp/worker.py * Fix line length Co-authored-by: liuyixin <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 0fef0a3)
5 tasks
asvetlov
pushed a commit
that referenced
this pull request
Oct 27, 2021
Co-authored-by: liuyixin <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 0fef0a3) Co-authored-by: harrylyx <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
🐛 Fix resetting SIGCHLD signals in Gunicorn aiohttp Worker to fix subprocesses that capture output having an incorrect returncode.
Are there changes in behavior for the user?
No
Related issue number
Fix #6130
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.