Add test for default Expect handler#601
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Jan 29, 2016
Merged
Conversation
Server should return 417 if any of the expectations cannot be met. http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20
Contributor
Author
|
Currently expect handler called only if value of Expect header is "100-continue" It would be much better if default handler could return 417 in case of unknown value of this field. |
Member
|
Sorry for delay. I think the current behavior should be fixed. Please provide a patch. @fafhrd91 you've added support for |
Member
|
+1 |
Contributor
Author
|
I have a doubt. In fact 100-continue is only one known Expect header. This change makes code more strict but slightly harder to use. |
Contributor
Author
|
@asvetlov ping |
Member
|
Let's postpone it until aiohttp 0.19 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server should return 417 if any of the expectations cannot be met.
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20