Skip to content

auto_decompress is optional in server#5958

Merged
asvetlov merged 9 commits intoaio-libs:masterfrom
p4l1ly:server_auto_decompress
Oct 24, 2021
Merged

auto_decompress is optional in server#5958
asvetlov merged 9 commits intoaio-libs:masterfrom
p4l1ly:server_auto_decompress

Conversation

@p4l1ly
Copy link
Copy Markdown
Contributor

@p4l1ly p4l1ly commented Aug 19, 2021 •
edited by asvetlov
Loading

What do these changes do?

auto_decompress was able to be disabled for client but unfortunately not for server. I've exported the API for server.

Are there changes in behavior for the user?

The change should be backward compatible, I've only added an optional argument.

Related issue number

Fixes #5957

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 19, 2021
@p4l1ly
Copy link
Copy Markdown
Contributor Author

p4l1ly commented Oct 5, 2021

@asvetlov @webknjaz what do you think?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2021 •
edited
Loading

Codecov Report

Merging #5958 (77edae3) into master (47ab6df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5958   +/-   ##
=======================================
  Coverage   93.34%   93.35%           
=======================================
  Files         102      102           
  Lines       30112    30128   +16     
  Branches     2694     2694           
=======================================
+ Hits        28109    28125   +16     
  Misses       1829     1829           
  Partials      174      174
Flag Coverage Δ
unit 93.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_protocol.py 86.41% <ø> (ø)
tests/test_web_functional.py 97.96% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ab6df...77edae3. Read the comment docs.

asvetlov
asvetlov reviewed Oct 24, 2021
View reviewed changes
asvetlov
asvetlov reviewed Oct 24, 2021
View reviewed changes
@asvetlov asvetlov enabled auto-merge (squash) October 24, 2021 11:40
@asvetlov asvetlov merged commit 50b8830 into aio-libs:master Oct 24, 2021
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Oct 24, 2021 •
edited
Loading

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 50b8830 on top of patchback/backports/3.8/50b8830d6cf395fc1fcca903d3ad19987e18be8b/pr-5958

Backporting merged PR #5958 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/3.8/50b8830d6cf395fc1fcca903d3ad19987e18be8b/pr-5958 upstream/3.8
  4. Now, cherry-pick PR auto_decompress is optional in server #5958 contents into that branch: 
    $ git cherry-pick -x 50b8830d6cf395fc1fcca903d3ad19987e18be8b
    If it'll yell at you with something like fatal: Commit 50b8830d6cf395fc1fcca903d3ad19987e18be8b is a merge but no -m option was given., add -m 1 as follows intead: 
    $ git cherry-pick -m1 -x 50b8830d6cf395fc1fcca903d3ad19987e18be8b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR auto_decompress is optional in server #5958 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/3.8/50b8830d6cf395fc1fcca903d3ad19987e18be8b/pr-5958
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@aio-libs-github-bot
Copy link
Copy Markdown
Contributor

aio-libs-github-bot bot commented Oct 24, 2021

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Oct 24, 2021
@p4l1ly @asvetlov @pre-commit-ci
auto_decompress is optional in server (#5958)
f7c2e3d 
Co-authored-by: Pavol Vargovcik <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov left review comments

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

optional auto_decompress for HttpRequestParser

2 participants

@p4l1ly @asvetlov