Skip to content

fix: remove deprecated loop argument for asnycio.sleep/gather calls#5928

Merged
Dreamsorcerer merged 1 commit intoaio-libs:masterfrom
Hanaasagi:fix-warning
Aug 3, 2021
Merged

fix: remove deprecated loop argument for asnycio.sleep/gather calls#5928
Dreamsorcerer merged 1 commit intoaio-libs:masterfrom
Hanaasagi:fix-warning

Conversation

@Hanaasagi
Copy link
Copy Markdown
Member

@Hanaasagi Hanaasagi commented Aug 3, 2021

What do these changes do?

Remove deprecated loop argument for asnycio.sleep and asyncio.gather calls.

Are there changes in behavior for the user?

No.

Related issue number

Closes #5905 .

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@Hanaasagi Hanaasagi requested a review from asvetlov as a code owner August 3, 2021 11:58
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 3, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2021

Codecov Report

Merging #5928 (dd3a891) into master (33a38b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5928   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          44       44           
  Lines        9852     9852           
  Branches     1591     1591           
=======================================
  Hits         9532     9532           
  Misses        182      182           
  Partials      138      138           
Flag Coverage Δ
unit 96.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 99.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a38b8...dd3a891. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit a341986 into aio-libs:master Aug 3, 2021
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Aug 3, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/a341986d9e4f577bc879ad4f45a77aaf08ced4f6/pr-5928

Backported as #5929

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.10 compatibility — deprecated loop argument for asnycio.sleep/gather calls

2 participants