Skip to content

Remove external test dependency to http://httpbin.org#5843

Merged
webknjaz merged 4 commits intoaio-libs:masterfrom
derlih:issue_5840
Oct 20, 2021
Merged

Conversation

@derlih
Copy link
Copy Markdown
Contributor

@derlih derlih commented Jun 30, 2021

What do these changes do?

Remove external test dependency to http://httpbin.org

Are there changes in behavior for the user?

No

Related issue number

#5840

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@derlih derlih requested a review from asvetlov as a code owner June 30, 2021 17:27
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 30, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #5843 (e40e1a9) into master (816e0bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5843   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files         102      102           
  Lines       30063    30066    +3     
  Branches     2690     2689    -1     
=======================================
+ Hits        28054    28057    +3     
  Misses       1833     1833           
  Partials      176      176
Flag Coverage Δ
unit 93.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_formdata.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816e0bc...e40e1a9. Read the comment docs.

@derlih derlih linked an issue Jun 30, 2021 that may be closed by this pull request
tests/test_formdata.py::test_mark_formdata_as_processed relies on external web server #5840
Closed
1 task
@webknjaz webknjaz enabled auto-merge (squash) October 20, 2021 12:15
@webknjaz webknjaz added this to the 3.8 milestone Oct 20, 2021
@webknjaz webknjaz merged commit 728505c into aio-libs:master Oct 20, 2021
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Oct 20, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/728505c119e6abe96968f13567aaa7e4cbcdbe8f/pr-5843

Backported as #6112

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 20, 2021
@derlih
Remove external test dependency to http://httpbin.org (#5843)
cb476e8 
(cherry picked from commit 728505c)
@patchback patchback bot mentioned this pull request Oct 20, 2021
Merged
5 tasks
webknjaz pushed a commit that referenced this pull request Oct 20, 2021
@patchback @derlih
[PR #5843/728505c1 backport][3.8] Remove external test dependency to h…
61c4f31 
…ttp://httpbin.org (#6112)

Co-authored-by: Dmitry Erlikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

3.8

Development

Successfully merging this pull request may close these issues.

tests/test_formdata.py::test_mark_formdata_as_processed relies on external web server

2 participants

@derlih @webknjaz