Remove leftover usage of the attrs library in runtime#5811
Remove leftover usage of the attrs library in runtime#5811RawatDevanshu wants to merge 8 commits intoaio-libs:masterfrom RawatDevanshu:master
Conversation
| ) | ||
|
|
||
| import attr | ||
| import dataclasses |
There was a problem hiding this comment.
I'd move this after the line 2 for consistency.
| attrs==20.3.0 | ||
| # via | ||
| # -r requirements/lint.txt | ||
| # flake8-pyi | ||
| # pytest |
There was a problem hiding this comment.
Don't edit this file, it's managed automatically. In this case, attrs comes in as a transitive dependency as visible in the comment.
|
Additionally to the inline comments, you need to drop https://github.com/aio-libs/aiohttp/blob/fd2ea56/tests/autobahn/Dockerfile.aiohttp#L8-L17. |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
|
Hi, any interest in finishing this PR? Appears there are 2 minor changes needed (moving the import and reverting the changes to requirements files). |
|
Or enable the option to "Allow commits from maintainer" so I can finish it...? |
You can still do this by fetching their branch and pushing to your fork. |
|
Well, they've actually deleted their repo, so looks like I'd need to copy manually from their diff and figure out how to attribute them in Git. I think it's probably faster for me to redo it from scratch. |
|
Replaced by #5960. |
|
(educational comment) @Dreamsorcerer FYI this is how you can fetch read-only fork branches: |
fix #5806