Skip to content

Remove leftover usage of the attrs library in runtime#5811

Closed
RawatDevanshu wants to merge 8 commits intoaio-libs:masterfrom
RawatDevanshu:master
Closed

Remove leftover usage of the attrs library in runtime#5811
RawatDevanshu wants to merge 8 commits intoaio-libs:masterfrom
RawatDevanshu:master

Conversation

@RawatDevanshu
Copy link
Copy Markdown

fix #5806

Comment thread aiohttp/web_protocol.py
)

import attr
import dataclasses
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move this after the line 2 for consistency.

Comment thread aiohttp/web_protocol.py Outdated
Comment thread requirements/lint.txt
Comment thread requirements/dev.txt
Comment on lines -22 to -26
attrs==20.3.0
# via
# -r requirements/lint.txt
# flake8-pyi
# pytest
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit this file, it's managed automatically. In this case, attrs comes in as a transitive dependency as visible in the comment.

@webknjaz
Copy link
Copy Markdown
Member

@webknjaz webknjaz changed the title removed attr usage Remove leftover usage of the attrs library in runtime Jun 19, 2021
Comment thread aiohttp/web_protocol.py
@Dreamsorcerer
Copy link
Copy Markdown
Member

Hi, any interest in finishing this PR? Appears there are 2 minor changes needed (moving the import and reverting the changes to requirements files).

@Dreamsorcerer
Copy link
Copy Markdown
Member

Or enable the option to "Allow commits from maintainer" so I can finish it...?

@webknjaz
Copy link
Copy Markdown
Member

Or enable the option to "Allow commits from maintainer" so I can finish it...?

You can still do this by fetching their branch and pushing to your fork.

http://blog.rolpdog.com/2018/08/testing-and-modifying-github-prs.html

@webknjaz webknjaz added bot:chronographer:skip This PR does not need to include a change note and removed bot:chronographer:skip This PR does not need to include a change note labels Aug 20, 2021
@Dreamsorcerer
Copy link
Copy Markdown
Member

Well, they've actually deleted their repo, so looks like I'd need to copy manually from their diff and figure out how to attribute them in Git.

I think it's probably faster for me to redo it from scratch.

@Dreamsorcerer
Copy link
Copy Markdown
Member

Replaced by #5960.

@webknjaz
Copy link
Copy Markdown
Member

(educational comment) @Dreamsorcerer FYI this is how you can fetch read-only fork branches: git config --add remote.origin.fetch '+refs/pull/*/head:refs/pull/origin/*'. Provided that your origin points to this upstream repo, that is, change it if it isn't. Having done this once, it'll keep the PR branches up-to-date in your local repo with every git fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO] Finish wiping the attrs usage

3 participants