Codecov Report

Merging #5637 (1106d17) into master (407f708) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5637   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          41       41           
  Lines        8865     8865           
  Branches     1425     1425           
=======================================
  Hits         8615     8615           
  Misses        133      133           
  Partials      117      117           

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407f708...1106d17. Read the comment docs.

Used the crosbario/autobahn-testsuite:0.8.2 Docker image.

@webknjaz PTAL

What's happening with these tests? There was a build failure for Windows, so I tried rerunning them, but now they aren't running at all...

I'm curious if that's related with today's GHA outage

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 6fb3efc on top of patchback/backports/3.8/6fb3efc4b5dd971e3f0e1080435fead757f15eaa/pr-5637

Backporting merged PR #5637 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git add remote upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.8/6fb3efc4b5dd971e3f0e1080435fead757f15eaa/pr-5637 upstream/3.8

4. Now, cherry-pick PR Update client/server implementation in the autobahn tests #5637 contents into that branch:

   $ git cherry-pick -x 6fb3efc4b5dd971e3f0e1080435fead757f15eaa

   If it'll yell at you with something like fatal: Commit 6fb3efc4b5dd971e3f0e1080435fead757f15eaa is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x 6fb3efc4b5dd971e3f0e1080435fead757f15eaa

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Update client/server implementation in the autobahn tests #5637 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.8/6fb3efc4b5dd971e3f0e1080435fead757f15eaa/pr-5637

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@wefatherley mind backporting this?

Sure thing

It seems swapping out the deprecated _make_handler syntax can be backported to 3.2, while swapping out deprecated ws_connect syntax can be backported to 3.0? Does the cherry picker handle this on it's own?

It only does git cherry-pick -x and that's about it. Normally, if automatic backporting fails, it means that there's manual adjustments to be made.