Added Python 3.5 “async for” compat to websocket by flying-sheep · Pull Request #543 · aio-libs/aiohttp

flying-sheep · 2015-10-02T12:57:26Z

Instead of

while True:
    msg = await ws.receive()
    ...
    elif msg.tp == web.MsgType.close:
        break

do:

async for msg in ws:
    ...

flying-sheep · 2015-10-02T13:38:51Z

uh, those test failures are no my fault. i fixed them in #544

flying-sheep · 2015-10-02T18:05:52Z

triggering rebuild

flying-sheep · 2015-10-02T18:21:08Z

hmm, OK, now the error is:

$ flake8 aiohttp
aiohttp/web_ws.py:297:19: F821 undefined name 'StopAsyncIteration'

but this is wrong. of course this is an undefined name in python < 3.5, but as you’d have to call ws.__anext__() manually in those versions, and you don’t do that because it’s a magic method wrapping receive.

so i’ll just make flake8 shut up.

asvetlov · 2015-10-03T08:49:06Z

Tests and documentation update are required

flying-sheep · 2015-10-03T19:21:59Z

i don’t seem to get this test to run. it hangs, don’t know why…

carlcarl · 2015-10-04T05:49:07Z

In Travis log: aiohttp/web_ws.py:295:1: W293 blank line contains whitespace.
There are spaces at line 295.
(The testing use flake8 to check the coding style at the beginning)

flying-sheep · 2015-10-04T11:23:26Z

i know, i just made a last-minute fix and didn’t run it after 😐

check the new one, that’s the real problem.

carlcarl · 2015-10-04T19:35:03Z

Seems hangs on test_web_websocket.py line 42:

msg = await resp._reader.read()

In resp._reader.read(), check streams.py line 374:

yield from self._waiter

It stops there I guess...

flying-sheep · 2015-10-04T21:02:32Z

ya. why?

carlcarl · 2015-10-05T11:59:52Z

Here is the part of the my testing in test_await:

    items = ['q1', 'q2', 'q3']
    for item in items:
        resp._writer.send(item)
        msg = await resp._reader.read()
        assert msg.tp == websocket.MSG_TEXT
        assert item + '/answer' == msg.data

    resp._writer.close()

    msg = await resp._reader.read()
    assert msg.tp == websocket.MSG_CLOSE
    assert msg.data == 1000
    assert msg.extra == ''

    await closed
    await resp.close()

Server will not know if it need to send close message back. So you need to send close first or it will wait for receive forever.

Also, remember to await resp.close()

flying-sheep · 2015-10-06T17:27:49Z

thanks! you saved me quite some time. 🙇

i copied the test from elsewhere and adapted it … poorly.

i hope this is it then!

Instead of while True: msg = await ws.receive() ... elif msg.tp == web.MsgType.close: break do: async for msg in ws: ...

asvetlov · 2015-10-18T15:40:38Z

tests/test_py35/test_web_websocket_35.py

Why do you need private attribute access. The test may use send() and receive() client response methods.

eh, no idea, i copied stuff from elsewhere. what methods are you referring to?

resp._writer.send(item) ?
I think he means _writer is a private attribute and should not be used in testing.

sure. my question is what i should use instead

http://aiohttp.readthedocs.org/en/stable/client_websockets.html

flying-sheep · 2015-10-25T13:16:08Z

oh, sorry. i would have done it eventually 😅

lock · 2019-10-29T23:03:35Z

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

flying-sheep closed this Oct 2, 2015

flying-sheep reopened this Oct 2, 2015

flying-sheep force-pushed the patch-3 branch from ed89874 to 433130c Compare October 3, 2015 19:21

flying-sheep force-pushed the patch-3 branch 2 times, most recently from 401f1e3 to 48ae89e Compare October 4, 2015 12:49

flying-sheep force-pushed the patch-3 branch from 48ae89e to eba2a5e Compare October 6, 2015 17:26

flying-sheep force-pushed the patch-3 branch from eba2a5e to 970925c Compare October 6, 2015 17:32

asvetlov mentioned this pull request Oct 12, 2015

aiohttp 0.18 release #564

Closed

flying-sheep force-pushed the patch-3 branch from 970925c to 27082a6 Compare October 18, 2015 13:22

Added Python 3.5 “async for” compat to websocket

c3da779

Instead of while True: msg = await ws.receive() ... elif msg.tp == web.MsgType.close: break do: async for msg in ws: ...

flying-sheep force-pushed the patch-3 branch from 27082a6 to c3da779 Compare October 18, 2015 13:24

asvetlov reviewed Oct 18, 2015
View reviewed changes

asvetlov merged commit c3da779 into aio-libs:master Oct 24, 2015

flying-sheep deleted the patch-3 branch October 25, 2015 13:12

lock bot added the outdated label Oct 29, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019

Uh oh!

Conversation

flying-sheep commented Oct 2, 2015

Uh oh!

flying-sheep commented Oct 2, 2015

Uh oh!

flying-sheep commented Oct 2, 2015

Uh oh!

flying-sheep commented Oct 2, 2015

Uh oh!

asvetlov commented Oct 3, 2015

Uh oh!

flying-sheep commented Oct 3, 2015

Uh oh!

carlcarl commented Oct 4, 2015

Uh oh!

flying-sheep commented Oct 4, 2015

Uh oh!

carlcarl commented Oct 4, 2015

Uh oh!

flying-sheep commented Oct 4, 2015

Uh oh!

carlcarl commented Oct 5, 2015

Uh oh!

flying-sheep commented Oct 6, 2015

Uh oh!

asvetlov Oct 18, 2015

Choose a reason for hiding this comment

Uh oh!

flying-sheep Oct 18, 2015

Choose a reason for hiding this comment

Uh oh!

carlcarl Oct 18, 2015

Choose a reason for hiding this comment

Uh oh!

flying-sheep Oct 18, 2015

Choose a reason for hiding this comment

Uh oh!

asvetlov Oct 19, 2015

Choose a reason for hiding this comment

Uh oh!

flying-sheep commented Oct 25, 2015

Uh oh!

lock bot commented Oct 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants