Replace AbstractMatchInfo with UrlMappingMatchInfo. by Dreamsorcerer · Pull Request #5328 · aio-libs/aiohttp

Dreamsorcerer · 2020-12-09T15:05:09Z

If I understood the comment on that issue correctly, this is the change that should be made.

Dreamsorcerer · 2020-12-09T15:06:08Z

+
+        if allowed_methods:
+            return MatchInfoError(HTTPMethodNotAllowed(method, allowed_methods))
        else:


I dropped the else here, as it is redundant, and makes it a little more difficult to see that the function will always return.
(The diff is a little awkward to look at, as it's split it weirdly, but all I've done is remove the else following the for).

codecov · 2020-12-09T15:10:36Z

Codecov Report

Merging #5328 (268c575) into master (dab21a4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 268c575 differs from pull request most recent head 8cb4b6f. Consider uploading reports for the commit 8cb4b6f to get more accurate results

@@           Coverage Diff           @@
##           master    #5328   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          44       44           
  Lines        9857     9857           
  Branches     1592     1592           
=======================================
  Hits         9537     9537           
  Misses        182      182           
  Partials      138      138

Flag	Coverage Δ
unit	`96.65% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiohttp/web_app.py	`97.33% <100.00%> (ø)`
aiohttp/web_middlewares.py	`100.00% <100.00%> (ø)`
aiohttp/web_urldispatcher.py	`97.83% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab21a4...8cb4b6f. Read the comment docs.

lgtm-com · 2020-12-09T15:24:43Z

This pull request fixes 1 alert when merging 7cf6819 into cb4bae7 - view on LGTM.com

fixed alerts:

1 for Unnecessary 'else' clause in loop

lgtm-com · 2021-09-30T20:47:17Z

This pull request fixes 1 alert when merging 268c575 into dab21a4 - view on LGTM.com

fixed alerts:

1 for Unnecessary 'else' clause in loop

Bumps [multidict](https://github.com/aio-libs/multidict) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/aio-libs/multidict/releases) - [Changelog](https://github.com/aio-libs/multidict/blob/master/CHANGES.rst) - [Commits](aio-libs/multidict@v5.1.0...v5.2.0) --- updated-dependencies: - dependency-name: multidict dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lgtm-com · 2021-10-04T12:14:19Z

This pull request fixes 1 alert when merging b498bea into 3ae013e - view on LGTM.com

fixed alerts:

1 for Unnecessary 'else' clause in loop

Bumps [sqren/backport-github-action](https://github.com/sqren/backport-github-action) from 1.0.40 to 1.0.41. - [Release notes](https://github.com/sqren/backport-github-action/releases) - [Commits](sorenlouv/backport-github-action@v1.0.40...v1.0.41) --- updated-dependencies: - dependency-name: sqren/backport-github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lgtm-com · 2021-10-05T12:18:12Z

This pull request fixes 1 alert when merging 4aea1c5 into 1b4b89c - view on LGTM.com

fixed alerts:

1 for Unnecessary 'else' clause in loop

Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.5 to 6.0.1. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](coveragepy/coveragepy@coverage-5.5...6.0.1) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [yarl](https://github.com/aio-libs/yarl) from 1.6.3 to 1.7.0. - [Release notes](https://github.com/aio-libs/yarl/releases) - [Changelog](https://github.com/aio-libs/yarl/blob/master/CHANGES.rst) - [Commits](aio-libs/yarl@v1.6.3...v1.7.0) --- updated-dependencies: - dependency-name: yarl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lgtm-com · 2021-10-07T12:18:21Z

This pull request fixes 1 alert when merging 9ea5fbc into c9c9bec - view on LGTM.com

fixed alerts:

1 for Unnecessary 'else' clause in loop

Bumps [multidict](https://github.com/aio-libs/multidict) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/aio-libs/multidict/releases) - [Changelog](https://github.com/aio-libs/multidict/blob/master/CHANGES.rst) - [Commits](aio-libs/multidict@v5.1.0...v5.2.0) --- updated-dependencies: - dependency-name: multidict dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.12.1 to 3.0.0. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v2.12.1...v3.0.0) --- updated-dependencies: - dependency-name: pytest-cov dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [flake8](https://github.com/pycqa/flake8) from 3.9.2 to 4.0.0. - [Release notes](https://github.com/pycqa/flake8/releases) - [Commits](PyCQA/flake8@3.9.2...4.0.0) --- updated-dependencies: - dependency-name: flake8 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [coverage](https://github.com/nedbat/coveragepy) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](coveragepy/coveragepy@6.0.1...6.0.2) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [flake8](https://github.com/pycqa/flake8) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/pycqa/flake8/releases) - [Commits](PyCQA/flake8@4.0.0...4.0.1) --- updated-dependencies: - dependency-name: flake8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2.3.4...v2.3.5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [frozenlist](https://github.com/aio-libs/frozenlist) from 1.1.1 to 1.2.0. - [Release notes](https://github.com/aio-libs/frozenlist/releases) - [Changelog](https://github.com/aio-libs/frozenlist/blob/master/CHANGES.rst) - [Commits](aio-libs/frozenlist@v1.1.1...v1.2.0) --- updated-dependencies: - dependency-name: frozenlist dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [aiosignal](https://github.com/aio-libs/aiosignal) from 1.1.2 to 1.2.0. - [Release notes](https://github.com/aio-libs/aiosignal/releases) - [Changelog](https://github.com/aio-libs/aiosignal/blob/master/CHANGES.rst) - [Commits](aio-libs/aiosignal@v1.1.2...v1.2.0) --- updated-dependencies: - dependency-name: aiosignal dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

asvetlov · 2021-10-26T09:27:18Z

Superseded by #6135

Replace AbstractMatchInfo with UrlMappingMatchInfo.

d119094

Dreamsorcerer requested a review from asvetlov as a code owner December 9, 2020 15:05

Dreamsorcerer commented Dec 9, 2020

View reviewed changes

Create 4748.bugfix

7cf6819

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 9, 2020

Dreamsorcerer added the backport-3.8 label Jan 7, 2021

Dreamsorcerer mentioned this pull request Sep 30, 2021

Add support for Python 3.10 and musl-based runtimes aio-libs/multidict#629

Merged

Merge branch 'master' into master

268c575

asvetlov added this to the 3.8 milestone Oct 1, 2021

github-actions bot requested a review from webknjaz as a code owner October 4, 2021 12:05

dependabot bot added 2 commits October 7, 2021 13:05

dependabot bot added 10 commits October 8, 2021 13:04

asvetlov mentioned this pull request Oct 26, 2021

Replace AbstractMatchInfo with UrlMappingMatchInfo. #6135

Merged

asvetlov closed this Oct 26, 2021

patchback bot mentioned this pull request Oct 27, 2021

[PR #6135/40646d07 backport][3.8] Replace AbstractMatchInfo with UrlMappingMatchInfo. #6137

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace AbstractMatchInfo with UrlMappingMatchInfo.#5328

Replace AbstractMatchInfo with UrlMappingMatchInfo.#5328
Dreamsorcerer wants to merge 17 commits intoaio-libs:masterfrom
Dreamsorcerer:master

Dreamsorcerer commented Dec 9, 2020

Uh oh!

Dreamsorcerer Dec 9, 2020 •

edited

Loading

Uh oh!

codecov bot commented Dec 9, 2020 •

edited

Loading

Uh oh!

lgtm-com bot commented Dec 9, 2020

Uh oh!

lgtm-com bot commented Sep 30, 2021

Uh oh!

lgtm-com bot commented Oct 4, 2021

Uh oh!

lgtm-com bot commented Oct 5, 2021

Uh oh!

lgtm-com bot commented Oct 7, 2021

Uh oh!

asvetlov commented Oct 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Dreamsorcerer commented Dec 9, 2020

Uh oh!

Dreamsorcerer Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lgtm-com bot commented Dec 9, 2020

Uh oh!

lgtm-com bot commented Sep 30, 2021

Uh oh!

lgtm-com bot commented Oct 4, 2021

Uh oh!

lgtm-com bot commented Oct 5, 2021

Uh oh!

lgtm-com bot commented Oct 7, 2021

Uh oh!

asvetlov commented Oct 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dreamsorcerer Dec 9, 2020 •

edited

Loading

codecov bot commented Dec 9, 2020 •

edited

Loading