Fix race condition on connect when tracing is active (#5259)#5285
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Nov 26, 2020
Merged
Fix race condition on connect when tracing is active (#5259)#5285asvetlov merged 1 commit intoaio-libs:masterfrom
asvetlov merged 1 commit intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #5285 +/- ##
==========================================
- Coverage 97.54% 97.53% -0.02%
==========================================
Files 43 43
Lines 8794 8789 -5
Branches 1415 1410 -5
==========================================
- Hits 8578 8572 -6
- Misses 101 103 +2
+ Partials 115 114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Nov 26, 2020
Member
|
Thanks! |
Contributor
💚 Backport successfulThe PR was backported to the following branches:
|
asvetlov
added a commit
that referenced
this pull request
Nov 26, 2020
…5285) (#5291) Co-authored-by: Bob Haddleton <[email protected]> Co-authored-by: Andrew Svetlov <[email protected]>
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acquire the connection before running traces, to prevent race condition.
This change will ensure that the limit and limit_per_host functionality in BaseConnector works when traces are configured.
NOTE: Unit tests are TBD as this is an async race condition which is extremely difficult to unit test. Suggestions are welcome.
Related issue number
Fixes #5259
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.