Skip to content

Extend precision of access log "D" to milliseconds#527

Merged
asvetlov merged 2 commits intoaio-libs:masterfrom
sterwill:master
Sep 24, 2015
Merged

Extend precision of access log "D" to milliseconds#527
asvetlov merged 2 commits intoaio-libs:masterfrom
sterwill:master

Conversation

@sterwill
Copy link
Copy Markdown
Contributor

The fractional time part had a precision of 10 milliseconds
due to a too-short truncation of the time string. This commit
adds one digit and includes a test for the case.

Fixes issue #524

The fractional time part had a precision of 10 milliseconds
due to a too-short truncation of the time string.  This commit
adds one digit and includes a test for the case.
@sterwill
Copy link
Copy Markdown
Contributor Author

The PR says "T" but I meant to say "D" (the fractional time part). Luckily I extended the right one in the implementation.

@asvetlov asvetlov changed the title Extend precision of access log "T" to milliseconds Extend precision of access log "D" to milliseconds Sep 24, 2015
@asvetlov
Copy link
Copy Markdown
Member

PR title updated.

@asvetlov
Copy link
Copy Markdown
Member

Please fix the following pyflakes error:

$ flake8 aiohttp examples tests
tests/test_helpers.py:1:1: F401 'datetime' imported but unused

asvetlov added a commit that referenced this pull request Sep 24, 2015
Extend precision of access log "D" to milliseconds
@asvetlov asvetlov merged commit 92cd425 into aio-libs:master Sep 24, 2015
@asvetlov
Copy link
Copy Markdown
Member

Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants