Update close status codes ws#5198
Merged
asvetlov merged 6 commits intoaio-libs:masterfrom Nov 23, 2020
Merged
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #5198 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 43 43
Lines 8784 8786 +2
Branches 1413 1413
=======================================
+ Hits 8568 8570 +2
Misses 101 101
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Nov 23, 2020
Member
asvetlov
left a comment
asvetlov
left a comment
There was a problem hiding this comment.
LGTM
Eventually we should find a way to support a open range with unknown-yet return codes.
Contributor
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
asvetlov
pushed a commit
that referenced
this pull request
Nov 23, 2020
(cherry picked from commit f82f084) Co-authored-by: Dmitry Erlikh <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Nov 23, 2020
(cherry picked from commit f82f084) Co-authored-by: Dmitry Erlikh <[email protected]> Co-authored-by: Dmitry Erlikh <[email protected]>
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add ABNORMAL_CLOSURE and BAD_GATEWAY to WSCloseCode
Are there changes in behavior for the user?
No
Related issue number
Fixes #5192
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.