Skip to content

Customize the input buffer size#5065

Merged
asvetlov merged 8 commits intomasterfrom
pass-limits
Oct 17, 2020
Merged

Customize the input buffer size#5065
asvetlov merged 8 commits intomasterfrom
pass-limits

Conversation

@asvetlov
Copy link
Copy Markdown
Member

Fixes #4453

@asvetlov asvetlov requested a review from webknjaz as a code owner October 17, 2020 13:46
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 17, 2020
@asvetlov asvetlov merged commit 56e7883 into master Oct 17, 2020
@asvetlov asvetlov deleted the pass-limits branch October 17, 2020 20:22
@github-actions
Copy link
Copy Markdown
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.7: Commit could not be cherrypicked due to conflicts

@tseaver
Copy link
Copy Markdown

tseaver commented Oct 26, 2020

Making limit a required positional argument (removing the default) is a breaking change: see pnuckowski/aioresponses#173

@asvetlov
Copy link
Copy Markdown
Member Author

Sorry but no. StreamReader.__init__ is a private API, user code should never call it.
aioresponses mocks aiohttp internals for its work.
I cannot prevent it (but discourage, sure).
The breakage of such libraries when aiohttp changes own internal undocumented API is the expected thing unfortunately.

@tseaver
Copy link
Copy Markdown

tseaver commented Oct 28, 2020

I'm not sure I understand how the constructor of a public class (aiohttp.streams.StreamReader is even imported into aiohttp/__init__.py!) can be considered "private". I do see the note in the docs that users aren't to instantiate the class, but that is a very unusual claim.

@asvetlov
Copy link
Copy Markdown
Member Author

Sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Line is too long" for JSON-lines from Kubernetes API

2 participants