[3.7] Don't cancel web handler on disconnection (#4080)#4771
Merged
asvetlov merged 4 commits intoaio-libs:3.7from Oct 17, 2020
Jackenmen:backport-4080-3.7
Merged
[3.7] Don't cancel web handler on disconnection (#4080)#4771asvetlov merged 4 commits intoaio-libs:3.7from Jackenmen:backport-4080-3.7
asvetlov merged 4 commits intoaio-libs:3.7from
Jackenmen:backport-4080-3.7
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## 3.7 #4771 +/- ##
==========================================
+ Coverage 97.56% 97.94% +0.38%
==========================================
Files 44 44
Lines 8953 8964 +11
Branches 1408 1410 +2
==========================================
+ Hits 8735 8780 +45
+ Misses 110 78 -32
+ Partials 108 106 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 3.7 #4771 +/- ##
==========================================
- Coverage 97.62% 97.27% -0.36%
==========================================
Files 44 44
Lines 9020 9033 +13
Branches 1419 1422 +3
==========================================
- Hits 8806 8787 -19
- Misses 95 124 +29
- Partials 119 122 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Oct 17, 2020
Member
|
Thanks! |
This was referenced Nov 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Backport #4080 to aiohttp 3.7. I'm not sure whether there's gonna be another 3.6 release or if 3.7 is still planned but this allows to handle connections issues properly so would be good to have.
Are there changes in behavior for the user?
ConnectionResetErroris raised on writing to closing transport instead of a warning.Related issue number
#4080
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.