Fix "Usage" docstring of aiohttp.client.request#4604
Merged
webknjaz merged 2 commits intoaio-libs:masterfrom Mar 19, 2020
Merged
Fix "Usage" docstring of aiohttp.client.request#4604webknjaz merged 2 commits intoaio-libs:masterfrom
webknjaz merged 2 commits intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
wereii
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4604 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 43 43
Lines 8907 8907
Branches 1404 1404
=======================================
Hits 8691 8691
Misses 96 96
Partials 120 120 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix wrong "Usage" of
aiohttp.client.request's docstring (function returns context manager).Are there changes in behavior for the user?
Better, reflecting docstring!
Related issue number
Fixes #4603
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.