Make web.BaseRequest and web.StreamResponse weak referenceable#4375
Merged
asvetlov merged 3 commits intoaio-libs:masterfrom Nov 25, 2019
Merged
Make web.BaseRequest and web.StreamResponse weak referenceable#4375asvetlov merged 3 commits intoaio-libs:masterfrom
asvetlov merged 3 commits intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4375 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 43 43
Lines 8861 8861
Branches 1389 1389
=======================================
Hits 8641 8641
Misses 96 96
Partials 124 124
Continue to review full report at Codecov.
|
Contributor
Author
|
@asvetlov could you draft a new alpha release after this is merged? This bug causes issues on production for me, installing aiohttp from source is not easy |
|
@Fogapod I mean, you're running an alpha version of aiohttp, right? |
Contributor
Author
|
I'm currently on |
asvetlov
approved these changes
Nov 25, 2019
Member
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adding
__weakref__to__slots__makesweb.BaseRequestandweb.StreamResponsevalid targets for creating weak references.Are there changes in behavior for the user?
Users are able to create weak references to request and response objects again after #3942.
Related issue number
Resolves #4368
Resolves #4370
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.