Added properties of default ClientSession params to ClientSession class#4240
Merged
asvetlov merged 3 commits intoaio-libs:masterfrom Oct 20, 2019
Merged
Added properties of default ClientSession params to ClientSession class#4240asvetlov merged 3 commits intoaio-libs:masterfrom
asvetlov merged 3 commits intoaio-libs:masterfrom
Conversation
…ss so it is available for introspection now
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4240 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 43 43
Lines 8841 8841
Branches 1383 1383
=======================================
Hits 8625 8625
Misses 93 93
Partials 123 123Continue to review full report at Codecov.
|
asvetlov
requested changes
Oct 20, 2019
Member
asvetlov
left a comment
asvetlov
left a comment
There was a problem hiding this comment.
The code is correct.
Please document added public attributes in ./docs/client_reference.rst.
Please use .. versionadded:: 3.7 tag
aiohttp/client.py
Outdated
| return self._timeout | ||
|
|
||
| @property | ||
| def default_headers(self) -> 'CIMultiDict[str]': |
Member
There was a problem hiding this comment.
Suggested change
| def default_headers(self) -> 'CIMultiDict[str]': | |
| def headers(self) -> 'CIMultiDict[str]': |
Let's keep property names in sync with constructor parameters
…default_headers property to headers so that it matches the constructor of the ClientSession
asvetlov
approved these changes
Oct 20, 2019
Member
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Oct 20, 2019
…on class (#4240) (cherry picked from commit 5f291b0) Co-authored-by: Pavel Filatov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Oct 20, 2019
…on class (#4240) (#4242) * [3.6] Added properties of default ClientSession params to ClientSession class (#4240) (cherry picked from commit 5f291b0) Co-authored-by: Pavel Filatov <[email protected]>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Added properties of default ClientSession params to ClientSession class so it is available for introspection now
Are there changes in behavior for the user?
Users can now see which default parameters were initialized with ClientSession
Related issue number
This commit fixes #3882
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.