Fixed ProxyConnector ignoring verify_ssl, ssl_context#421
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Jun 27, 2015
panda73111:master
Merged
Fixed ProxyConnector ignoring verify_ssl, ssl_context#421asvetlov merged 1 commit intoaio-libs:masterfrom panda73111:master
asvetlov merged 1 commit intoaio-libs:masterfrom
panda73111:master
Conversation
Member
|
The patch looks good but test is required. Mocking connection is ok. |
Contributor
Author
|
Sure thing. However, I'm not familiar with python unit tests, so it will take a few days. I'll have a look at the existing tests. |
Member
|
Please do. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ProxyConnector calls loop.create_connection(ssl=True), where a new default ssl context is then created. This causes the exception "ClientOSError: Cannot connect to host ..." to be raised when connecting to websites with self signed certificates, even after passing verify_ssl=False to ProxyConnector.
Using this patch, the ProxyConnector passes the ssl context created in its superclass TCPConnector (in dependence of verify_ssl) to loop.create_connection().