[3.6] Update docs to clarify proxy support (#4101)#4110
Merged
Conversation
* Update docs to clarify proxy support Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 . * Create 1400.doc Record change * Update docs/client_advanced.rst Differentiate types of HTTP proxies. Co-Authored-By: Andrew Svetlov <[email protected]> (cherry picked from commit be95c61) Co-authored-by: Benjamin Kane <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 3.6 #4110 +/- ##
=========================================
- Coverage 98.1% 98.06% -0.05%
=========================================
Files 44 44
Lines 8867 8867
Branches 1391 1391
=========================================
- Hits 8699 8695 -4
- Misses 63 66 +3
- Partials 105 106 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via
https://- #4100 .