Merged
Conversation
webknjaz
approved these changes
Aug 19, 2019
Member
|
Thanks @Transfusion! |
1 task
Contributor
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 7a59a14 on top of patchback/backports/3.10/7a59a1480b7cca4779c62fe35be778415121cd71/pr-3991 Backporting merged PR #3991 into master
🤖 @patchback |
steverep
pushed a commit
to steverep/aiohttp
that referenced
this pull request
Jul 10, 2024
PR aio-libs#3991 by @Transfusion (cherry picked from commit 7a59a14)
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Jul 10, 2024
Missed backport of PR #3991 by @Transfusion (cherry picked from commit 7a59a14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds
FileResponseconstructor parameters to the documentation, based on the parentStreamResponseclass documentation.Related issue number
Resolves #3958
Checklist
CHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.