Set reason to an empty string if it is missing (_http_parser.pyx)#3909
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Jul 22, 2019
WouldYouKindly:fix-parsing-http-reason-phrase
Merged
Set reason to an empty string if it is missing (_http_parser.pyx)#3909asvetlov merged 1 commit intoaio-libs:masterfrom WouldYouKindly:fix-parsing-http-reason-phrase
asvetlov merged 1 commit intoaio-libs:masterfrom
WouldYouKindly:fix-parsing-http-reason-phrase
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3909 +/- ##
==========================================
- Coverage 97.76% 97.73% -0.03%
==========================================
Files 43 43
Lines 8620 8620
Branches 1380 1380
==========================================
- Hits 8427 8425 -2
- Misses 82 83 +1
- Partials 111 112 +1
Continue to review full report at Codecov.
|
asvetlov
requested changes
Jul 19, 2019
Member
asvetlov
left a comment
asvetlov
left a comment
There was a problem hiding this comment.
Looks good, please add CHANGES file
Contributor
Author
|
@asvetlov done. |
asvetlov
pushed a commit
that referenced
this pull request
Jul 22, 2019
…x) (#3909) (cherry picked from commit 8d1f067) Co-authored-by: Alexey <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jul 22, 2019
…x) (#3909) (#3922) (cherry picked from commit 8d1f067) Co-authored-by: Alexey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #3906
Test that if reason is missing, it is set to an empty string rather than any falsy value.
Make cython parser set it to en empty string if it is missing.
self._reason = self._reason or ''is because_on_status_completeis called from two places and when it's called the second time, reason may already be set.