Conversation
…un_app finalization.
Codecov Report
@@ Coverage Diff @@
## master #3500 +/- ##
==========================================
- Coverage 97.93% 97.92% -0.02%
==========================================
Files 44 44
Lines 8560 8562 +2
Branches 1380 1381 +1
==========================================
+ Hits 8383 8384 +1
Misses 72 72
- Partials 105 106 +1
Continue to review full report at Codecov.
|
asvetlov
added a commit
that referenced
this pull request
Jan 8, 2019
* Fix #3497: Ignore done tasks when cancels pending activities on web.run_app finalization. (cherry picked from commit 4e99e81) Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jan 8, 2019
* Fix #3497: Ignore done tasks when cancels pending activities on web.run_app finalization. (cherry picked from commit 4e99e81) Co-authored-by: Andrew Svetlov <[email protected]>
cognifloyd
added a commit
to cognifloyd/connexion
that referenced
this pull request
May 22, 2019
Somewhere between 3.5.1 and 3.5.2, the aiohttp reimport started succeeding (in connexion.connexion.cli.run()). It's not clear which change caused the issue, but it's probably one of: - aio-libs/aiohttp#3469 (Remove wildcard imports) - aio-libs/aiohttp#3464 (Don't suppress gunicorn cleanup errors) - aio-libs/aiohttp#3471 (Refactor workers) - aio-libs/aiohttp#3500 (Ignore done tasks) In any case, setting sys.modules['aiohttp'] = None should prevent reimporting it. See: https://stackoverflow.com/a/1350574 I successfully tested locally on py37 with aiohttp 3.5.1 and 3.5.2.
hjacobs
pushed a commit
to spec-first/connexion
that referenced
this pull request
Oct 15, 2019
* Revert "set max aiohttp version to 3.5.1 (until build is fixed) (#844)" This reverts commit b2a4287. * Fix test_run_with_aiohttp_not_installed Somewhere between 3.5.1 and 3.5.2, the aiohttp reimport started succeeding (in connexion.connexion.cli.run()). It's not clear which change caused the issue, but it's probably one of: - aio-libs/aiohttp#3469 (Remove wildcard imports) - aio-libs/aiohttp#3464 (Don't suppress gunicorn cleanup errors) - aio-libs/aiohttp#3471 (Refactor workers) - aio-libs/aiohttp#3500 (Ignore done tasks) In any case, setting sys.modules['aiohttp'] = None should prevent reimporting it. See: https://stackoverflow.com/a/1350574 I successfully tested locally on py37 with aiohttp 3.5.1 and 3.5.2.
psf-chronographer
bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3497