Conversation
|
Its too radical. I'm working on improvements and I think lots of envs are acceptable but only on when run cron. |
That's why I'd like to keep the PR merged. |
|
Sure, I'm not implying unmerging it. It's just the way it's solved is a bit conflicting with my ideas. We still need tox-based envs in place when I get to it... |
|
I feel uncomfortable with tox when working on daily tasks:
|
|
@webknjaz |
|
Currently, travis fails on about 10-15% runs.
This is because
pytest-xdistplugin executes tests in several threads to speed up the time.The intention is good, the benefit is obvious but some aiohttp tests require the main thread context to setup Unix signal handlers.
The PR refactors tests running strategy.
pytest-xdistis removeduvloopare dropped. Before the change, every async tests was executed twice: with asyncio loop and uvloop, doubling the execution time. The last and only problem with uvloop was sendfile usage, found and fixed about 3 or 4 years ago.PYTHONASYNCIODEBUGrun was removed, several tests for explicit debug loop was added instead.AIOHTTP_NO_EXTENSIONSrun was removed from every job run but added an explicit job for making sure that aiohttp works without C extensions.As the result: