Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
=========================================
- Coverage 97.96% 97.9% -0.06%
=========================================
Files 44 44
Lines 8489 8497 +8
Branches 1376 1375 -1
=========================================
+ Hits 8316 8319 +3
- Misses 74 77 +3
- Partials 99 101 +2
Continue to review full report at Codecov.
|
socketpair
reviewed
Nov 6, 2018
socketpair
reviewed
Nov 6, 2018
socketpair
reviewed
Nov 6, 2018
socketpair
reviewed
Nov 6, 2018
socketpair
reviewed
Nov 6, 2018
socketpair
reviewed
Nov 6, 2018
socketpair
reviewed
Nov 6, 2018
5 tasks
socketpair
reviewed
Nov 7, 2018
psf-chronographer
bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is using
add_done_callbackto unregister writer early on future cancellation.