Skip to content

Fix test infra#3337

Merged
asvetlov merged 3 commits intoaio-libs:masterfrom
zhangyunhao116:master
Oct 10, 2018
Merged

Fix test infra#3337
asvetlov merged 3 commits intoaio-libs:masterfrom
zhangyunhao116:master

Conversation

@zhangyunhao116
Copy link
Copy Markdown
Contributor

@zhangyunhao116 zhangyunhao116 commented Oct 10, 2018 •
edited
Loading

Fix test infra

Nope

Nope

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 10, 2018 •
edited
Loading

Codecov Report

Merging #3337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3337   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          44       44           
  Lines        8039     8039           
  Branches     1357     1357           
=======================================
  Hits         7878     7878           
  Misses         67       67           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9483209...b0c0f3f. Read the comment docs.

@asvetlov asvetlov merged commit dc7eab9 into aio-libs:master Oct 10, 2018
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Oct 10, 2018

Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangyunhao116 @codecov-io @asvetlov