Add default logging handler to web.run_app (#3243)#3324
Merged
asvetlov merged 5 commits intoaio-libs:masterfrom Nov 24, 2018
Merged
Add default logging handler to web.run_app (#3243)#3324asvetlov merged 5 commits intoaio-libs:masterfrom
asvetlov merged 5 commits intoaio-libs:masterfrom
Conversation
aio-libs-bot
added
good first issue
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
=========================================
- Coverage 98.01% 98% -0.02%
=========================================
Files 43 43
Lines 8025 8030 +5
Branches 1356 1359 +3
=========================================
+ Hits 7866 7870 +4
Misses 66 66
- Partials 93 94 +1
Continue to review full report at Codecov.
|
0az
force-pushed
the
fix-3243
branch
2 times, most recently
from
b11d4e5 to
a746006
Compare
asvetlov
reviewed
Oct 6, 2018
webknjaz
reviewed
Oct 6, 2018
webknjaz
approved these changes
Oct 6, 2018
Member
|
@0az could you please come up with some sort of a regression test? |
0az
changed the title
Author
|
Not sure what's going on with codecov. In any case, now that there's a set of tests, I think this can be merged. |
Closed
Member
|
@0az thanks! |
psf-chronographer
bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3243.
What do these changes do?
Add a default logging handler to
web.run_app.Are there changes in behavior for the user?
If the
Application.debugflag is set and the default loggeraiohttp.accessis used, access logs will now be output using astderrStreamHandlerif no handlers are attached. Furthermore, if the default logger has no log level set, the log level will be set toDEBUG.Related issue number
This issue fixes #3243.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.