Fix ping / pong default message#3308
Merged
asvetlov merged 3 commits intoaio-libs:masterfrom Oct 1, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3308 +/- ##
==========================================
- Coverage 98.07% 98.03% -0.04%
==========================================
Files 43 43
Lines 8001 8001
Branches 1354 1354
==========================================
- Hits 7847 7844 -3
- Misses 63 65 +2
- Partials 91 92 +1
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Oct 1, 2018
Member
|
Thanks. Funny typo |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
psf-chronographer
bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix typo in default message for ping and pong methods
Are there changes in behavior for the user?
Ping and pong frames sent by server will not set default message as 'b' anymore
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.