Skip to content

normalize_path_middleware should keep the query string. #3278

Merged
asvetlov merged 5 commits intoaio-libs:masterfrom
linw1995:master
Sep 20, 2018
Merged

normalize_path_middleware should keep the query string. #3278
asvetlov merged 5 commits intoaio-libs:masterfrom
linw1995:master

Conversation

@linw1995
Copy link
Copy Markdown
Contributor

@linw1995 linw1995 commented Sep 19, 2018 •
edited
Loading

normalize_path_middleware should keep the query string.

  1. first commit reveals the bug.
    the query string should the same, after transforming by the middleware.
    image

  2. second commit for bugfix

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Sep 19, 2018

Nice catch!

Could you please reorder imports using isort? https://travis-ci.com/aio-libs/aiohttp/jobs/146631131#L742

@webknjaz webknjaz requested review from argaen and asvetlov September 19, 2018 12:24
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 19, 2018 •
edited
Loading

Codecov Report

Merging #3278 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3278      +/-   ##
==========================================
- Coverage   98.03%   97.99%   -0.04%     
==========================================
  Files          43       43              
  Lines        7894     7894              
  Branches     1354     1354              
==========================================
- Hits         7739     7736       -3     
- Misses         63       65       +2     
- Partials       92       93       +1
Impacted Files Coverage Δ
aiohttp/web_middlewares.py 100% <100%> (ø) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b112b0...204fe72. Read the comment docs.

webknjaz
webknjaz approved these changes Sep 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now it's @asvetlov's turn

asvetlov
asvetlov approved these changes Sep 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asvetlov asvetlov merged commit 6cb85a7 into aio-libs:master Sep 20, 2018
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Sep 20, 2018

Thanks!

@terrisgit
Copy link
Copy Markdown

terrisgit commented Dec 17, 2018 •
edited
Loading

Me needs this fix. The last aiohttp release happened on Sep 5. This fix just barely missed it.

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Dec 17, 2018

See #3384 for the next release updates

@lock
Copy link
Copy Markdown

lock bot commented Dec 17, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Dec 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@webknjaz webknjaz webknjaz approved these changes

@argaen argaen Awaiting requested review from argaen

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@linw1995 @webknjaz @codecov-io @asvetlov @terrisgit