Skip to content

Don't uppercase HTTP verb in parser#3233

Merged
asvetlov merged 2 commits intomasterfrom
no-uppercase-http-verb
Sep 2, 2018
Merged

Don't uppercase HTTP verb in parser#3233
asvetlov merged 2 commits intomasterfrom
no-uppercase-http-verb

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Sep 1, 2018 •
edited
Loading

RFC 7320 sec. 3.1.1:

The request method is case sensitive

webknjaz
webknjaz approved these changes Sep 1, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Now it's more RFC-compliant :)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 1, 2018

Codecov Report

Merging #3233 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3233      +/-   ##
==========================================
- Coverage   98.07%   98.07%   -0.01%     
==========================================
  Files          43       43              
  Lines        7857     7856       -1     
  Branches     1354     1354              
==========================================
- Hits         7706     7705       -1     
  Misses         59       59              
  Partials       92       92
Impacted Files Coverage Δ
aiohttp/http_parser.py 98.06% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7206f4...73d6530. Read the comment docs.

@kxepal kxepal mentioned this pull request Sep 2, 2018
Merged
@asvetlov asvetlov merged commit 7b71302 into master Sep 2, 2018
@asvetlov asvetlov deleted the no-uppercase-http-verb branch September 2, 2018 06:47
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@webknjaz webknjaz webknjaz approved these changes

@kxepal kxepal kxepal approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asvetlov @codecov-io @webknjaz @kxepal