Codecov Report

Merging #3209 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
- Coverage   98.11%   98.07%   -0.04%     
==========================================
  Files          43       43              
  Lines        7853     7853              
  Branches     1354     1354              
==========================================
- Hits         7705     7702       -3     
- Misses         57       59       +2     
- Partials       91       92       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0af887...147f4a8. Read the comment docs.

@webknjaz I doubt if we should bump to not-released-yet versions of http-parser.
According to their log the last is 2.8.1: https://github.com/nodejs/http-parser/releases/tag/v2.8.1

Fair enough. But it has some fixes, which may be related to #3208

Which commit from http-parser unreleased master fixes #3208 ?

It seems to be nodejs/http-parser@a7c2e86 from history, but needs verification.

Well. Let's keep the PR but avoid bumps to unreleased versions in the future.

Got it

FTR sticking to tags didn't save us from pulling their bugs :)

Can confirm that doing this fixed #3208

Ok, thank you

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new