Skip to content

Improve lingering logic and documentation#3152

Merged
asvetlov merged 7 commits intoaio-libs:masterfrom
Harmon758:improve-lingering
Oct 22, 2018
Merged

Improve lingering logic and documentation#3152
asvetlov merged 7 commits intoaio-libs:masterfrom
Harmon758:improve-lingering

Conversation

@Harmon758
Copy link
Copy Markdown
Member

@Harmon758 Harmon758 commented Jul 23, 2018 •
edited
Loading

What do these changes do?

Improve logic for lingering and documentation of Application.make_handler parameters

Are there changes in behavior for the user?

No

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 23, 2018 •
edited
Loading

Codecov Report

Merging #3152 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files          44       44              
  Lines        8332     8331       -1     
  Branches     1369     1369              
==========================================
- Hits         8168     8167       -1     
  Misses         68       68              
  Partials       96       96
Impacted Files Coverage Δ
aiohttp/web_protocol.py 92.5% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e40f1...6e98d15. Read the comment docs.

asvetlov
asvetlov reviewed Jul 25, 2018
View reviewed changes
@Harmon758 Harmon758 requested a review from webknjaz as a code owner October 21, 2018 21:40
@asvetlov asvetlov merged commit ac05737 into aio-libs:master Oct 22, 2018
@webknjaz webknjaz requested a review from asvetlov October 22, 2018 10:43
@Harmon758 Harmon758 deleted the improve-lingering branch October 22, 2018 11:26
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Harmon758 @codecov-io @asvetlov