Skip to content

Raise ConnectionReserError instead of CancelledError#2989

Merged
asvetlov merged 2 commits intomasterfrom
minor-fix
May 10, 2018
Merged

Raise ConnectionReserError instead of CancelledError#2989
asvetlov merged 2 commits intomasterfrom
minor-fix

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented May 10, 2018

on trying to write to a closed stream.

@asvetlov asvetlov mentioned this pull request May 10, 2018
Closed
kxepal
kxepal reviewed May 10, 2018
View reviewed changes
CHANGES/2499.feature Outdated
@@ -0,0 +1,2 @@
Raise ``ConnectionReserError`` instead of ``CancelledError`` on trying
Copy link
Copy Markdown
Member

@kxepal kxepal May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConnectionResetError

Copy link
Copy Markdown
Member Author

@asvetlov asvetlov May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 10, 2018 •
edited
Loading

Codecov Report

Merging #2989 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
- Coverage   98.09%   98.09%   -0.01%     
==========================================
  Files          42       42              
  Lines        7676     7675       -1     
  Branches     1338     1338              
==========================================
- Hits         7530     7529       -1     
  Misses         49       49              
  Partials       97       97
Impacted Files Coverage Δ
aiohttp/http_writer.py 97.91% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1223d4b...36cad79. Read the comment docs.

@asvetlov asvetlov merged commit 9541960 into master May 10, 2018
@asvetlov asvetlov deleted the minor-fix branch May 10, 2018 12:47
@decaz decaz mentioned this pull request Mar 12, 2019
Closed
@balloob balloob mentioned this pull request Apr 10, 2019
Merged
@azhpushkin azhpushkin mentioned this pull request Apr 16, 2019
Closed
@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kxepal kxepal kxepal approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asvetlov @codecov-io @kxepal