Skip to content

Fix resources __repr__ formatting#2935

Merged
asvetlov merged 1 commit intoaio-libs:masterfrom
vadim-su:patch-2
Apr 13, 2018
Merged

Fix resources __repr__ formatting#2935
asvetlov merged 1 commit intoaio-libs:masterfrom
vadim-su:patch-2

Conversation

@vadim-su
Copy link
Copy Markdown
Contributor

@vadim-su vadim-su commented Apr 13, 2018

What do these changes do?

Cosmetic change.
Now, when printing resources, they will have a closing bracket.

I broke my head reading this:

[<StaticResource 'debugtoolbar.static' /_debugtoolbar/static -> PosixPath('/usr/local/lib/python3.6/site-packages/aiohttp_debugtoolbar/static'), <PlainResource 'debugtoolbar.source'  /_debugtoolbar/source, <PlainResource 'debugtoolbar.execute'  /_debugtoolbar/execute, <PlainResource 'debugtoolbar.exception'  /_debugtoolbar/exception, <PlainResource 'debugtoolbar.sse'  /_debugtoolbar/sse, <DynamicResource 'debugtoolbar.request'  /_debugtoolbar/{request_id}, <PlainResource 'debugtoolbar.main'  /_debugtoolbar, <PlainResource  /users/, <DynamicResource  /users/{user_id}, <PlainResource  /login, <PlainResource  /whoami, <PlainResource  /cars/, <DynamicResource  /cars/{car_id}, <DynamicResource  /cars/{car_id}/upload_image, <PlainResource  /cars/search, <PlainResource  /cars/brands/, <PlainResource  /cars/types/]

@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Apr 13, 2018

Would you add CHANGES note?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 13, 2018 •
edited
Loading

Codecov Report

Merging #2935 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2935   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          40       40           
  Lines        7513     7513           
  Branches     1318     1318           
=======================================
  Hits         7362     7362           
  Misses         48       48           
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd1185...88f445f. Read the comment docs.

@vadim-su
Copy link
Copy Markdown
Contributor Author

vadim-su commented Apr 13, 2018

Made the required changes.
Updated the commit.

@asvetlov asvetlov merged commit 55a6782 into aio-libs:master Apr 13, 2018
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Apr 13, 2018

Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vadim-su @asvetlov @codecov-io